Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix playbook to run terminal on remote hosts as wel #107

Merged
merged 27 commits into from
May 27, 2021
Merged

fix playbook to run terminal on remote hosts as wel #107

merged 27 commits into from
May 27, 2021

Conversation

dspolleke
Copy link
Contributor

#102
also added tag

@dspolleke dspolleke mentioned this pull request Apr 14, 2021
Closed
geerlingguy
geerlingguy requested changes May 15, 2021
View reviewed changes
Copy link
Owner

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase so this only includes the relevant changes?

@geerlingguy
Copy link
Owner

It seems like you may be doing a merge/rebase, which means all the other changes are mixed in when I try previewing it on GitHub: https://github.com/geerlingguy/mac-dev-playbook/pull/107/files

Can you do a git rebase master and then git push --force—or alternately maybe just delete this PR/branch and create a new one? I could go grab the .patch from this PR and do it myself but it might be faster for you to :)

dspolleke and others added 14 commits May 26, 2021 10:47
@dspolleke
fix tags issue 97
87dd16f
@dspolleke
fixed it the way GG wants it fixed
5f77296
@dspolleke
imclude_tasks are sometimes useful
e50edb3
@dspolleke
edited Readme to reflect work allready done.
874d83e 
Removed some work obviously already done. 
I am working on the vim stuff and sublime stuff. Did you allready put the mouse tracking in de .osx file?
do you know of any way to configure the mentioned accounts on the cli?
@dspolleke
dock util from https://github.com/enlewof \n Fixed default value for …
baae72b 
…variable, \ncreated block (for tags to work), \nFixed some strong language, \N fixed some shell / command preference (ansible-lint)
@dspolleke
working dockutil
2574bb2
@dspolleke
yamllinter
63659ca
@dspolleke
requested changes
5b47a10
@dspolleke
conditionals are hard
c32d37e
@geerlingguy @dspolleke
PR geerlingguy#106 follow-up: More consistent docs and examples.
bd6b7a0
@dspolleke
fix terminal to run with remote tasks as well
269e925
@dspolleke
rebase
6aad473
@dspolleke
did i mention i really hate rebasing
ffcb2a6
@dspolleke
empty array
018ed6b
geerlingguy
geerlingguy requested changes May 27, 2021
View reviewed changes
main.yml Outdated
@@ -39,6 +39,18 @@

- import_tasks: tasks/extra-packages.yml
tags: ['extra-packages']
- name: Install global Ruby gems.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some other commits/changes made it to this PR too, including some different inventory bits too, and a few changes to the default config...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated main.yml and invetory to remove those

geerlingguy
geerlingguy requested changes May 27, 2021
View reviewed changes
main.yml Outdated Show resolved Hide resolved
requirements.yml Outdated Show resolved Hide resolved
geerlingguy
geerlingguy approved these changes May 27, 2021
View reviewed changes
tasks/terminal.yml Outdated Show resolved Hide resolved
@geerlingguy
Copy link
Owner

To keep the task in conformity with the other playbook tasks for now, I'm not using the 'FQCN' to call the copy module. At some point in the future I'll upgrade all my work to use FQCNs, but would rather not have them mixed in for now.

@geerlingguy geerlingguy merged commit ae52135 into geerlingguy:master May 27, 2021
geerlingguy added a commit that referenced this pull request May 27, 2021
@geerlingguy
After merging #107, can drop -i inventory.
de1aec4
gabrielpedepera pushed a commit to gabrielpedepera/mac-dev-playbook that referenced this pull request Jan 6, 2022
Merge branch 'master' of github.com:geerlingguy/mac-dev-playbook
519b966 
* 'master' of github.com:geerlingguy/mac-dev-playbook: (63 commits)
  Close windows when empty. Please.
  Fixes geerlingguy#127: Replace Sequel Pro with Sequel Ace.
  update link to ChromeDriver (geerlingguy#128)
  Don't create a new window at startup on Mac in Sublime Text.
  Fixes geerlingguy#119: Remove extraneous Ansible setup tasks.
  Tweak one direction in install instructions [skip ci].
  Another tweak to the initial install instructions.
  Make first-time setup instructions slightly more succint. And correct.
  Fix CI for new collections-based world.
  Fixes geerlingguy#116: Switch from roles and dock tasks to geerlingguy.mac collection.
  Automate Sublime Text configuration (geerlingguy#117)
  Add /opt/homebrew/bin to example PATH in install instructions.
  After merging geerlingguy#107, can drop -i inventory.
  Update tasks/terminal.yml
  remove remove double double code code
  cleanup reuirements on request
  cleanup persoal crud
  cleanup persoal crud
  cleanup persoal crud
  Fix formatting from previous commit.
  ...
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Mar 7, 2022
@geerlingguy
Merge pull request geerlingguy#107 from dspolleke/terminal
d067c42 
fix playbook to run terminal on remote hosts as wel
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Mar 7, 2022
@geerlingguy
After merging geerlingguy#107, can drop -i inventory.
b08bd4d
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Jan 23, 2024
@geerlingguy @fabiogomezdiaz
After merging geerlingguy#107, can drop -i inventory.
d98ffaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geerlingguy geerlingguy geerlingguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dspolleke @geerlingguy