-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEO term URIs are different from Golr #17
Comments
cc @kltm Almost. Golr doesn't care much what goes in the id field. Currently the OWLTools loader will contract to OBO-style IDs (using a needs-to-die OWLTools-Core method), producing IDs like MGI:MGI:1336172 . These get passed on Minerva, which expands them using it's CURIE map, giving the jax URL. But the URI in Minerva's TBox comes from Neo. ugh |
OK, I think the correct fix is to adapt the OWLTools-core golr loader to use a prefixmap, but this is a bit of work. A workaround is to make minerva aggressively defensive, distrust and rewrite its own TBox. Ugh. |
Does your comment mean that it is correct for these terms to use the OBO prefix within NEO? |
Once @yy20716 implements this: owlcollab/owltools#245 I will have neo export the same URIs that are used by minerva |
Hmm, it looks like is configured to take from any branch not master, which means my PR has already leaked out
We need to make sure that the latest owltools (one that incorporates owlcollab/owltools#247) is used to load solr in this job: it seems this job failed for a different reason. |
@cmungall I believe I've cleared the "different reason" on that machine. |
I'm seeing updated identifiers in NEO now. In particular, I notice
|
On 22 May 2018, at 11:19, Jim Balhoff wrote:
I'm seeing updated identifiers in NEO now. In particular, I notice
`identifiers.org` for MGI and ZFIN. But, a couple of questions:
1. MGI IDs look like this: `http://identifiers.org/mgi/MGI%3A99582`.
Should they instead be `http://identifiers.org/mgi/MGI:99582`? As far
as I know the colon doesn't need to be encoded. Although it resolves
to the same place, it's not the same identifier.
yes, should use : directly
2. I seem some OBO-style ComplexPortal IDs:
`http://purl.obolibrary.org/obo/ComplexPortal_CPX-1`. Is that correct?
we just haven't gotten around to that one yet
…
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#17 (comment)
|
Noting that above comment on complex portal has not been resolved yet. |
there is a really horrific perl hack (my fault) in the neo pipeline, we
need to add this to the set of regexes, sorry...
…On Thu, Jul 23, 2020 at 2:36 PM goodb ***@***.***> wrote:
Noting that above comment on complex portal has not been resolved yet.
Minerva seems to think that
ComplexPortal:CPX-998 means
https://www.ebi.ac.uk/complexportal/complex/CPX-9
but NEO seems to think that it means
http://purl.obolibrary.org/obo/ComplexPortal_CPX-998
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMOPF4ADLEYUGOWUOJODR5CUL7ANCNFSM4DDOXZFQ>
.
|
In NEO, terms use OBO PURLs like http://purl.obolibrary.org/obo/MGI_MGI%3A1336172, but the autocomplete in Noctua produces terms like http://www.informatics.jax.org/accession/MGI:MGI:1336172 (which I assume comes from Golr). This is a problem for using NEO to get taxon metadata or to query models for instances of
molecular entity
.The text was updated successfully, but these errors were encountered: