Skip to content

Commit 56f7aef

Browse files
authored
Merge Excel Cell error (#498)
1 parent 0434ca8 commit 56f7aef

File tree

2 files changed

+31
-1
lines changed

2 files changed

+31
-1
lines changed

gxoffice/src/main/java/com/genexus/msoffice/excel/poi/xssf/ExcelCells.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -897,7 +897,7 @@ public Boolean mergeCells() {
897897
CellRangeAddress cellRange = new CellRangeAddress(rowStartIdx, rowEndIdx, colStartIdx, colEndIdx);
898898
for (int i = 0; i < pSelectedSheet.getNumMergedRegions(); i++){
899899
CellRangeAddress mergedRegion = pSelectedSheet.getMergedRegion(i);
900-
if (cellRange.intersects(cellRange)){
900+
if (cellRange.intersects(mergedRegion)){
901901
pSelectedSheet.removeMergedRegion(i);
902902
}
903903
}

gxoffice/src/test/java/com/genexus/msoffice/excel/ExcelSpreadsheetTest.java

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -617,6 +617,36 @@ public void testMergeCells() {
617617
excel.close();
618618
}
619619

620+
@Test
621+
public void testMergeMultipleCells() {
622+
ExcelSpreadsheetGXWrapper excel = create("testMergeCells-2");
623+
excel.getCells(1, 1, 2, 5).mergeCells();
624+
excel.getCells(1, 1, 2, 5).setText("merged cells 1");
625+
626+
excel.getCells(5, 1, 2, 5).mergeCells();
627+
excel.getCells(5, 1, 2, 5).setText("merged cells 2");
628+
629+
excel.getCells(8, 1, 2, 5).mergeCells();
630+
excel.getCells(8, 1, 2, 5).setText("merged cells 3");
631+
632+
excel.save();
633+
excel.close();
634+
}
635+
636+
@Test
637+
public void testMergeMultipleCellsIntersect() {
638+
ExcelSpreadsheetGXWrapper excel = create("testMergeCells-3");
639+
excel.getCells(1, 1, 8, 5).mergeCells();
640+
excel.getCells(1, 1, 8, 5).setText("merged cells 1");
641+
642+
excel.getCells(5, 1, 8, 5).mergeCells();
643+
excel.getCells(5, 1, 8, 5).setText("merged cells 2");
644+
645+
excel.save();
646+
excel.close();
647+
}
648+
649+
620650
@Test
621651
public void testMergeNestedCells() {
622652
ExcelSpreadsheetGXWrapper excel = create("testMergeNestedCells");

0 commit comments

Comments
 (0)