Skip to content

Commit 968d0ef

Browse files
committed
Fix format issues and change signature verification on RedirectBinding
1 parent 53dfed1 commit 968d0ef

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

gamsaml20/src/main/java/com/genexus/saml20/RedirectBinding.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import org.bouncycastle.crypto.Signer;
77
import org.bouncycastle.crypto.params.AsymmetricKeyParameter;
88
import org.bouncycastle.crypto.signers.RSADigestSigner;
9-
import org.bouncycastle.jcajce.provider.asymmetric.RSA;
109
import org.bouncycastle.util.encoders.Base64;
1110
import org.w3c.dom.Document;
1211

@@ -60,7 +59,7 @@ public boolean verifySignatures(SamlParms parms) {
6059
logger.debug("verifySignatures");
6160

6261
try {
63-
return DSig.validateSignatures(this.xmlDoc, parms.getTrustCertPath(), parms.getTrustCertAlias(), parms.getTrustCertPass());
62+
return verifySignature_internal(parms.getCertPath(), parms.getCertPass(), parms.getCertAlias());
6463
} catch (Exception e) {
6564
logger.error("verifySignature", e);
6665
return false;
@@ -102,8 +101,8 @@ public String getLoginAttribute(String name) {
102101

103102
// EXTERNAL OBJECT PUBLIC METHODS - END
104103

105-
private boolean VerifySignature_internal(String certPath, String certPass, String certAlias) {
106-
logger.trace("VerifySignature_internal");
104+
private boolean verifySignature_internal(String certPath, String certPass, String certAlias) {
105+
logger.trace("verifySignature_internal");
107106

108107
byte[] signature = Encoding.decodeParameter(this.redirectMessage.get("Signature"));
109108

@@ -127,7 +126,7 @@ private boolean VerifySignature_internal(String certPath, String certPass, Strin
127126
setUpSigner(signer, inputStream, Keys.getAsymmetricKeyParameter(cert), false);
128127
return signer.verifySignature(signature);
129128
} catch (Exception e) {
130-
logger.error("VerifySignature_internal", e);
129+
logger.error("verifySignature_internal", e);
131130
return false;
132131
}
133132
}

0 commit comments

Comments
 (0)