Skip to content

Commit 9c7fd77

Browse files
committed
Remove redundant isLevelEnabled when is not neccesrry
1 parent 9cb4760 commit 9c7fd77

File tree

1 file changed

+29
-63
lines changed

1 file changed

+29
-63
lines changed

wrappercommon/src/main/java/com/genexus/diagnostics/core/provider/Log4J2Logger.java

Lines changed: 29 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -3,30 +3,23 @@
33
import com.genexus.diagnostics.core.ILogger;
44

55
public class Log4J2Logger implements ILogger {
6-
7-
//Java implementation
8-
public Log4J2Logger (final Class<?> clazz) {
6+
private org.apache.logging.log4j.Logger log;
7+
8+
public Log4J2Logger(final Class<?> clazz) {
99
log = org.apache.logging.log4j.LogManager.getLogger(clazz);
1010
}
11-
12-
public Log4J2Logger (String clazz) {
11+
12+
public Log4J2Logger(String clazz) {
1313
log = org.apache.logging.log4j.LogManager.getLogger(clazz);
1414
}
15-
16-
org.apache.logging.log4j.Logger log = null;
17-
18-
15+
1916
@Override
2017
public void fatal(String msg) {
21-
if (log.isFatalEnabled()) {
22-
log.fatal(msg);
23-
}
18+
log.fatal(msg);
2419
}
25-
20+
2621
public void fatal(String msg, Throwable ex) {
27-
if (log.isFatalEnabled()) {
28-
log.fatal(msg, ex);
29-
}
22+
log.fatal(msg, ex);
3023
}
3124

3225
public void fatal(String msg1, String msg2, Throwable ex) {
@@ -44,15 +37,11 @@ public void fatal(Throwable ex, String[] list) {
4437
}
4538

4639
public void fatal(String[] list) {
47-
if (log.isFatalEnabled()) {
48-
fatal(null, list);
49-
}
40+
fatal(null, list);
5041
}
51-
42+
5243
public void error(String msg, Throwable ex) {
53-
if (log.isErrorEnabled()) {
54-
log.error(msg, ex);
55-
}
44+
log.error(msg, ex);
5645
}
5746

5847
public void error(String msg1, String msg2, Throwable ex) {
@@ -72,11 +61,9 @@ public void error(Throwable ex, String[] list) {
7261
public void error(String[] list) {
7362
error(null, list);
7463
}
75-
64+
7665
public void error(String msg) {
77-
if (log.isErrorEnabled()) {
78-
log.error(msg);
79-
}
66+
log.error(msg);
8067
}
8168

8269
public void warn(Throwable ex, String[] list) {
@@ -97,18 +84,14 @@ public void warn(String[] list) {
9784
}
9885

9986
public void warn(String msg, Throwable ex) {
100-
if (log.isWarnEnabled()) {
101-
log.warn(msg, ex);
102-
}
87+
log.warn(msg, ex);
10388
}
10489

10590
public void debug(String msg) {
106-
if (log.isDebugEnabled()) {
107-
log.debug(msg);
108-
}
91+
log.debug(msg);
10992
}
110-
111-
93+
94+
11295
public void debug(Throwable ex, String[] list) {
11396
if (log.isDebugEnabled()) {
11497
StringBuilder msg = new StringBuilder();
@@ -123,9 +106,7 @@ public void debug(Throwable ex, String[] list) {
123106
}
124107

125108
public void debug(String[] list) {
126-
if (log.isDebugEnabled()) {
127-
debug(null, list);
128-
}
109+
debug(null, list);
129110
}
130111

131112
// Lambda Functions not supported JAVA 7. Only Java 8.
@@ -142,9 +123,7 @@ public void debug(String msg1, String msg2, Throwable ex) {
142123
}
143124

144125
public void debug(String msg, Throwable ex) {
145-
if (log.isDebugEnabled()) {
146-
log.debug(msg, ex);
147-
}
126+
log.debug(msg, ex);
148127
}
149128

150129
public void info(String[] list) {
@@ -156,28 +135,19 @@ public void info(String[] list) {
156135
log.info(msg);
157136
}
158137
}
159-
138+
160139
public void info(String msg) {
161-
if (log.isInfoEnabled()) {
162-
log.info(msg);
163-
}
140+
log.info(msg);
164141
}
165-
142+
166143
public void warn(String msg) {
167-
if (log.isWarnEnabled()) {
168-
log.warn(msg);
169-
}
144+
log.warn(msg);
170145
}
171-
172146

173-
174147
public void trace(String msg) {
175-
if (log.isTraceEnabled()) {
176-
log.trace(msg);
177-
}
148+
log.trace(msg);
178149
}
179150

180-
181151
public void trace(Throwable ex, String[] list) {
182152
if (log.isTraceEnabled()) {
183153
StringBuilder msg = new StringBuilder();
@@ -192,9 +162,7 @@ public void trace(Throwable ex, String[] list) {
192162
}
193163

194164
public void trace(String[] list) {
195-
if (log.isTraceEnabled()) {
196-
trace(null, list);
197-
}
165+
trace(null, list);
198166
}
199167

200168
// Lambda Functions not supported JAVA 7. Only Java 8.
@@ -211,17 +179,15 @@ public void trace(String msg1, String msg2, Throwable ex) {
211179
}
212180

213181
public void trace(String msg, Throwable ex) {
214-
if (log.isTraceEnabled()) {
215-
log.trace(msg, ex);
216-
}
182+
log.trace(msg, ex);
217183
}
218-
184+
219185
public boolean isDebugEnabled() {
220186
return log.isDebugEnabled();
221187
}
222188

223189
public boolean isErrorEnabled() {
224190
return log.isErrorEnabled();
225191
}
226-
192+
227193
}

0 commit comments

Comments
 (0)