Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a dockerfile to build the sciClone package #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shenkers
Copy link

Hi @chrisamiller ,

I'm doing a volunteer project with a PI and wanted to run sciClone on the dataset. I saw that you had install instructions, but thought it might be nice for future visitors if there was a docker image. I guess ideally someone like biocontainers could host it so users don't have to build it, but thought even having the Dockerfile would make it easier for people to use.

Let me know if you have any feedback on the change.

Best,
Sol

@shenkers
Copy link
Author

update: it looks like the image doesn't work as is, I think because it runs in R v4, and something about how data-frame slicing by column index changed ( df[,1] used to return a vector, but now returns a 1-column data.frame? ). It looks like there are a lot of places that this sort of slicing is used, so it probably makes sense to use an R environment that mimics the original setup. I was browsing the issues and saw your reference to seqfu/sciclone docker image, it looks like theirs uses R 3.6.3 and BioConductor 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant