Configuration transactions #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If i got the contributing workflow totally wrong - i apologize. My thoughts have been - if i want to get my additions into your pull-request at the quarkus-repo i need to make a pull-request 1st to your branch in your repo-fork. |
|
Hi,
You need to create your pull request against
https://github.com/quarkusio/quarkus, not this repo :)
…On Wed, May 19, 2021 at 3:53 PM marcelhanser ***@***.***> wrote:
If i got the contributing workflow totally wrong - i apologize. My
thoughts have been - if i want to get my additions into your pull-request
at the quarkus-repo i need to make a pull-request 1st to your branch in
your repo-fork.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBMDPY2JEAU5LFYAQP4LDDTOOYGNANCNFSM45ETLPGA>
.
|
|
Hi, Thx for the fast response. Makes sense^^ I just did that, but now there are 2 pull-requests: |
|
Ah, now I see what you mean. What you have one in quarkusio#17357 is fine. I'll close my old PR in favor of yours |
marcelhanser
force-pushed
the
configuration-transactions
branch
2 times, most recently
from
4c41c6c
to
ffa831e
Compare
Pass max frame size to VertxServerWebSocketContainer
This is not perfect, as this information should be read from the plugin config, but it will prevent many issues. Relates to quarkusio#17558
Preserve TCCL when using coroutines in RESTEasy Reactive
…losingTarget()" This reverts the workaround from commit f6cffe0, but preserves the test. Assuming jandex indexes are always built with Jandex 2.3.0+, we no longer need this workaround.
…ng-on-class gRPC: support @Blocking on class
Update Vert.x Mutiny bindings to version 2.6.0 Update SmallRye Reactive Messaging to version: 3.4.0
Don't run maven IT names by default
Do not delete BrotliDecoder and let GraalVM DCE do it for us
Apply tiny polish to DevMojo
The current short option to display the version is "-V" (uppercase): `quarkus -V`. This is set by Picocli, but can be changed using the `picocli.version.name.0` property. The problem with `-V` is that does not match with the other short options to display version in the extensions and other commands which is "-v". Also, in other command tools like `mvn`, the option is `-v`. I did check that the `-v` is not conflicting with other existing options.
…ssdk.version-2.16.75 Bump awssdk.version from 2.16.74 to 2.16.75
Remove support for hibernate.properties (long deprecated)
…ive-messaging-mutiny-bindings Update Vert.x to version 4.1.0 and related dependencies
…test Add rule for @QuarkusIntegrationTest to the bot
Upgrade to Hibernate Reactive 1.0.0.CR6
Ensure @QuarkusIntegrationTest works properly with any Filesystem path
Also use the executor included in the container info even if the code was working ok. Fixes quarkusio#17571
…t-docs Update to GraphQL client user guide
…g.yaml-snakeyaml-1.29 Bump snakeyaml from 1.28 to 1.29
This simplifies things a lot and will also avoid race conditions.
This interface doesn't seem to be used anywhere
…he-kotlin-guide Create a MongoDB with Panache and Kotlin guide
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
Remove PlatformStack
Bumps [flyway-core](https://github.com/flyway/flyway) from 7.9.2 to 7.10.0. - [Release notes](https://github.com/flyway/flyway/releases) - [Commits](flyway/flyway@flyway-7.9.2...flyway-7.10.0) --- updated-dependencies: - dependency-name: org.flywaydb:flyway-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.20 to 42.2.21. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/REL42.2.21/CHANGELOG.md) - [Commits](pgjdbc/pgjdbc@REL42.2.20...REL42.2.21) --- updated-dependencies: - dependency-name: org.postgresql:postgresql dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Refactor Amazon Services initialization a bit
…g.flywaydb-flyway-core-7.10.0
…g.postgresql-postgresql-42.2.21
3 is the Micrometer default, 1024 is way to big and results in excessive memory usage.
…message Improve compile error message
Change ring buffer default length to 3
Improve mvn quarkus:test output
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
- Press [q] to quit - Accept live reload commands when tests are not running - Don't display live reload commands in quarkus:test - Fix quarkus:test if vertx-http was not present
…raphql-1.1.0 Upgrade to SmallRye GraphQL 1.2.5 and MicroProfile GraphQL 1.1.0
…ql-guide-update Update the SmallRye GraphQL Extension documentation
Polish console input
…pl-parentFirst Add org.apache.maven.resolver:maven-resolver-impl as parentFirstArtifact
Fix potential NPE in RESTEasy Classic build time processing
Resolves: quarkusio#15752
Resolves: quarkusio#15752
gsmet
force-pushed
the
configuration-transactions
branch
from
e727d9d
to
bbd8f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged main & implemented the caching remark.