Make unit test pass

[mablae]

Not all unit tests pass.

[willdurand]

Well, all tests are green:

% phpunit
PHPUnit 3.6.3 by Sebastian Bergmann.

Configuration read from […]/geocoder/phpunit.xml

................................................

Time: 5 seconds, Memory: 7.75Mb

OK (48 tests, 254 assertions)

If you have skipped tests, please read the "Unit Tests" section in the documentation.
If some tests are failing, please open a new issue with more information.

[mablae]

Thanks for your quick reply.

I am getting error when running tests: Seems to be my environment. Any hints about this:

--- TestGeocoder/Geocoder ‹master› » phpunit            
PHPUnit 3.6.3 by Sebastian Bergmann.

Configuration read from /home/malte/TestGeocoder/Geocoder/phpunit.xml.dist

..........EEEE...EEEESSESEEEEE..EEEEES..EEEESSES

Time: 2 seconds, Memory: 6.75Mb

There were 24 errors:

1) Geocoder\Tests\Provider\FreeGeoIpProviderTest::testGetGeocodedDataWithNull
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/FreeGeoIpProvider.php:41
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/FreeGeoIpProviderTest.php:14

2) Geocoder\Tests\Provider\FreeGeoIpProviderTest::testGetGeocodedDataWithEmpty
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/FreeGeoIpProvider.php:41
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/FreeGeoIpProviderTest.php:27

3) Geocoder\Tests\Provider\FreeGeoIpProviderTest::testGetGeocodedDataWithAddress
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/FreeGeoIpProvider.php:41
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/FreeGeoIpProviderTest.php:40

4) Geocoder\Tests\Provider\FreeGeoIpProviderTest::testGetGeocodedDataWithLocalhost
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/FreeGeoIpProviderTest.php:55

5) Geocoder\Tests\Provider\GoogleMapsProviderTest::testGetGeocodedData
Trying to get property of non-object

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/GoogleMapsProvider.php:81
/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/GoogleMapsProvider.php:55
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/GoogleMapsProviderTest.php:23

6) Geocoder\Tests\Provider\GoogleMapsProviderTest::testGetGeocodedDataWithNull
Trying to get property of non-object

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/GoogleMapsProvider.php:81
/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/GoogleMapsProvider.php:55
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/GoogleMapsProviderTest.php:36

7) Geocoder\Tests\Provider\GoogleMapsProviderTest::testGetGeocodedDataWithEmpty
Trying to get property of non-object

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/GoogleMapsProvider.php:81
/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/GoogleMapsProvider.php:55
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/GoogleMapsProviderTest.php:49

8) Geocoder\Tests\Provider\GoogleMapsProviderTest::testGetGeocodedDataWithLocalhost
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/GoogleMapsProviderTest.php:64

9) Geocoder\Tests\Provider\GoogleMapsProviderTest::testGetReversedData
Trying to get property of non-object

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/GoogleMapsProvider.php:81
/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/GoogleMapsProvider.php:55
/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/GoogleMapsProvider.php:63
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/GoogleMapsProviderTest.php:110

10) Geocoder\Tests\Provider\HostIpProviderTest::testGetGeocodedDataWithNull
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/HostIpProviderTest.php:16

11) Geocoder\Tests\Provider\HostIpProviderTest::testGetGeocodedDataWithEmpty
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/HostIpProviderTest.php:29

12) Geocoder\Tests\Provider\HostIpProviderTest::testGetGeocodedDataWithAddress
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/HostIpProviderTest.php:42

13) Geocoder\Tests\Provider\HostIpProviderTest::testGetGeocodedDataWithLocalhost
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/HostIpProviderTest.php:55

14) Geocoder\Tests\Provider\HostIpProviderTest::testGetGeocodedDataWithRealIp
Undefined index: zipcode

/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/HostIpProviderTest.php:71

15) Geocoder\Tests\Provider\IpInfoDbProviderTest::testGetGeocodedDataWithoutAdapter
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/IpInfoDbProvider.php:60
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/IpInfoDbProviderTest.php:23

16) Geocoder\Tests\Provider\IpInfoDbProviderTest::testGetGeocodedDataWithNull
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/IpInfoDbProvider.php:60
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/IpInfoDbProviderTest.php:36

17) Geocoder\Tests\Provider\IpInfoDbProviderTest::testGetGeocodedDataWithEmpty
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/IpInfoDbProvider.php:60
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/IpInfoDbProviderTest.php:49

18) Geocoder\Tests\Provider\IpInfoDbProviderTest::testGetGeocodedDataWithAddress
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/IpInfoDbProvider.php:60
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/IpInfoDbProviderTest.php:62

19) Geocoder\Tests\Provider\IpInfoDbProviderTest::testGetGeocodedDataWithLocalhost
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/IpInfoDbProviderTest.php:77

20) Geocoder\Tests\Provider\YahooProviderTest::testGetGeocodedData
Trying to get property of non-object

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/YahooProvider.php:91
/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/YahooProvider.php:55
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/YahooProviderTest.php:23

21) Geocoder\Tests\Provider\YahooProviderTest::testGetGeocodedDataWithNull
Trying to get property of non-object

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/YahooProvider.php:91
/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/YahooProvider.php:55
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/YahooProviderTest.php:36

22) Geocoder\Tests\Provider\YahooProviderTest::testGetGeocodedDataWithEmpty
Trying to get property of non-object

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/YahooProvider.php:91
/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/YahooProvider.php:55
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/YahooProviderTest.php:49

23) Geocoder\Tests\Provider\YahooProviderTest::testGetGeocodedDataWithLocalhost
Undefined index: latitude

/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/YahooProviderTest.php:64

24) Geocoder\Tests\Provider\YahooProviderTest::testGetReversedData
Trying to get property of non-object

/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/YahooProvider.php:91
/home/malte/TestGeocoder/Geocoder/src/Geocoder/Provider/YahooProvider.php:69
/home/malte/TestGeocoder/Geocoder/tests/Geocoder/Tests/Provider/YahooProviderTest.php:110

FAILURES!
Tests: 48, Assertions: 48, Errors: 24, Skipped: 7.

I have read the instructions to testing in Readme and downloaded \Buzz and \UniversalClassLoader.

Turning E_NOTICE off in php.ini

--- TestGeocoder/Geocoder ‹master› » phpunit                         
PHPUnit 3.6.3 by Sebastian Bergmann.

Configuration read from /home/malte/TestGeocoder/Geocoder/phpunit.xml.dist

.....................SS.S............S......SS.S

Time: 2 seconds, Memory: 5.75Mb

OK, but incomplete or skipped tests!
Tests: 48, Assertions: 213, Skipped: 7.

[willdurand]

mmh weird, let's reopen this issue =)

[mablae]

Hey,

I just digged deeper into PhpUnit and asked a guy over at #phpunit what is wrong - The tests or the code?

He said: run phpunit with -d error_reporting=32767

Which is E_ALL error_reporting...

Should I fix this issue? Since the error messages are very clear, I think I could to it. I'll send a PR when done.

[willdurand]

Yeah I'll be glad !

Le 10 nov. 2011 à 19:55, Malte Blättermannreply@reply.github.com a écrit :

Hey,

I just digged deeper into PhpUnit and asked a guy over at #phpunit what is wrong - The tests or the code?

He said: run phpunit with -d error_reporting=32767

Which is E_ALL error_reporting...

Should I fix this issue? Since the error messages are very clear, I think I could to it. I'll send a PR when done.

---

Reply to this email directly or view it on GitHub:
#8 (comment)

[willdurand]

Did you start a fix ?