Added a control to allow clearing selections #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After all queries have been removed from the selection tab, the selection polygon would continue to be displayed. This new functionality fixes that issue by adding a button allowing the user to clear the polygon. This was done as a bit of a compromise. Ostensibly, a complex selection area may need to be re-used even if the user wants to clear teh current results. Automatically removing the selection area would've made that impossible. Steps to use: 1. run a query with a drawn selection feature. 2. click "delete" / trash-can icon on the results. 3. See that there is now a polygon on display. 4. click the 'clear' button in the service manager tab.
|
This seems like fine grained control! Probably appreciated by those who know what it is and use it, probably ignored by many. Out of curiosity, what happens when you use this order for the steps?
|
|
The clear button is disabled when there is no polygon available to clear. If you do hit the clear button while drawing, it will just remove the currently in progress selection. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all queries have been removed from the selection tab,
the selection polygon would continue to be displayed.
This new functionality fixes that issue by adding a button
allowing the user to clear the polygon. This was done as a bit
of a compromise. Ostensibly, a complex selection area may need to be
re-used even if the user wants to clear teh current results. Automatically
removing the selection area would've made that impossible.
Steps to use:
refs: #257