Adding WFS-T editing to GeoMoose #620

theduckylittle · 2020-12-29T06:07:58Z

Big honking MR to add WFS-T editing capabilities to GeoMoose.

theduckylittle · 2021-02-08T05:28:25Z

src/gm3/components/map/index.js

+                        let queryFeature = util.featureToJson(evt.feature);
+                        const mapProjection = this.map.getView().getProjection();
+
+                        if (querySource.config['buffer-point']) {


@klassenjs and @brentfraser - Thoughts on this pattern for querying points/lines layers?

Related to #392, #536, #601. It's an OK fix. But someone should do some research on the OGC protocols to see if there is something in the protocol to do a spatial query by point geom.

brentfraser · 2021-02-27T19:21:49Z

Issue: Delete -> click on empty area (e.g. no polygon) shows "Remove ..." dialog (and clicking Okay shows error in console). No dialog should be shown.

brentfraser · 2021-02-27T19:22:38Z

Issue: Should the edit (and other?) tools be hidden when layer is turned off/disabled/not shown? Currently the legend is not shown in that case.

brentfraser · 2021-03-03T15:06:25Z

Issue: If the editable layer is accessed through the "Favourites" tab, no "Edit feature properties" dialog is shown.

brentfraser · 2021-03-03T22:24:06Z

Issue: Map tools (zoom in/out, end drawing buttons) obscure menu drop down choices. Change menu text from "Zoom to Full Extent" to "Full Extent", This move the other menu items slightly to the left. Start a feature edit, then click search and observe how the menu options are obscured by the Map tools.

brentfraser · 2021-03-03T23:36:48Z

Issue: When the WFS-T server is TinyOWS, and an attempt is made to edit properties on a features property values when they are all null, the fetch in wfs.js:171 fails:

               jsonFeature.properties.boundedBy = feature.getGeometry().getExtent();

because jsonFeature.properties is null (a little unexpected).

The fix is to test for null, and make the value an object:

                  if (jsonFeature.properties == null) {
                      jsonFeature.properties = [];
                  }
                  jsonFeature.properties.boundedBy = feature.getGeometry().getExtent();

or something similar.

GeoServer appears to include a "boundedBy" property by default, but TinyOWS does not.

theduckylittle · 2021-03-14T15:48:57Z

Issue: Delete -> click on empty area (e.g. no polygon) shows "Remove ..." dialog (and clicking Okay shows error in console). No dialog should be shown.

Fixed. Wrapped the entire block in the feature-length check.

Should the edit (and other?) tools be hidden when layer is turned off/disabled/not shown? Currently the legend is not shown in that case.

This really isn't an "issue" we could hide the tools. My initial thought is to keep them visible since they indicate the capabilities of the layer before it's turned on.

Issue: If the editable layer is accessed through the "Favourites" tab, no "Edit feature properties" dialog is shown.

Moved the Modals' definition to the map from the catalogs.

Map tools (zoom in/out, end drawing buttons) obscure menu drop down choices. Change menu text from "Zoom to Full Extent" to "Full Extent", This move the other menu items slightly to the left. Start a feature edit, then click search and observe how the menu options are obscured by the Map tools.

Added some more Z to the drawers in the toolbar.
Renamed the Zoom to Full Extent tool.

boundedBy

Added a safer mixin to prevent errors.

brentfraser · 2021-03-14T15:55:10Z

Should the edit (and other?) tools be hidden when layer is turned off/disabled/not shown? Currently the legend is not shown in that case.

This really isn't an "issue" we could hide the tools. My initial thought is to keep them visible since they indicate the capabilities of the layer before it's turned on.

Currently I put the editable layers in a separate group to indicate which are editable since that ability is so important to the user.

brentfraser · 2021-03-15T14:03:31Z

@theduckylittle The latest commits are awesome! I've tested my "Issues" and all the bugs are fixed. As for the issue/opinion of "hide edit tools", having a clean looking catalog/layer list is important (as is having an understandable UI). One solution is to have an edit icon at the same level of the "refresh" and "metadata" icons on the layer name:

and while we're at it, move the "Toggle legend visibility" icon up there too.

theduckylittle · 2021-03-15T14:05:28Z

@theduckylittle The latest commits are awesome! I've tested my "Issues" and all the bugs are fixed. As for the issue/opinion of "hide edit tools", having a clean looking catalog/layer list is important (as is having an understandable UI). One solution is to have an edit icon at the same level of the "refresh" and "metadata" icons on the layer name:

and while we're at it, move the "Toggle legend visibility" icon up there too.

I'm willing to open up the discussion on this. There are good/bad reasons for this and I'm willing to talk about them but not in this already monster sized pull request.

brentfraser · 2021-03-15T14:07:18Z

@theduckylittle A discussion on the layer controls would be great!

theduckylittle · 2021-03-15T14:09:24Z

@klassenjs - I believe this is ready for code review.

@brentfraser has done a very thorough job of testing the functionality. I suspect any more bugs will be corner cases are minor oversights that can be handled in a follow up PR.

Commits can/will be squashed appropriately after review.

I suspect it's okay for docs to come in as a separate PR. I think Brent has those in the works.

klassenjs

Also, it might be worth bumping the version in package.json before the merge. No way this is a precursor to 3.7.1. Not sure if we want to call this 3.8 or 4.0.

examples/desktop/app.js

tests/gm3/reducers/editor.test.js

klassenjs · 2021-03-16T04:45:59Z

Drawing and markup->Draw Point
Tries to scroll map instead of adding a point.

Actually seem to get locked in scroll at end of drawing any feature on Drawing and Markup (with mouse button up)

Associated with the following in the console

Uncaught TypeError: i.queryAs is null
    value http://localhost/GeoMoose/gm3/examples/geomoose/dist/geomoose.min.js:27
    dispatchEvent http://localhost/GeoMoose/gm3/examples/geomoose/dist/geomoose.min.js:27
    finishDrawing http://localhost/GeoMoose/gm3/examples/geomoose/dist/geomoose.min.js:38
    handleUpEvent http://localhost/GeoMoose/gm3/examples/geomoose/dist/geomoose.min.js:38
    handleEvent http://localhost/GeoMoose/gm3/examples/geomoose/dist/geomoose.min.js:27
    handleEvent http://localhost/GeoMoose/gm3/examples/geomoose/dist/geomoose.min.js:38
    handleMapBrowserEvent http://localhost/GeoMoose/gm3/examples/geomoose/dist/geomoose.min.js:38
    dispatchEvent http://localhost/GeoMoose/gm3/examples/geomoose/dist/geomoose.min.js:27
    handlePointerUp_ http://localhost/GeoMoose/gm3/examples/geomoose/dist/geomoose.min.js:83

klassenjs · 2021-03-16T04:51:13Z

The CSS changes are mostly subtle but it looks way nicer and feels more intuitive than before.

klassenjs · 2021-03-16T05:03:53Z

I'm still working on a Geoserver install.

1. Fix bug with joining "?" urls - Adds new util function to centralize cleanup logic. - Fixes vector map-source issue when there are trailing question marks. 2. Add built-in fixed editing layer. 3. Convert map controls to new react components 4. add keybindings for edit operations

…for point layer query

1. Add affordances to selected tools in the catalog. 2. Add signifiers to selected services in the toolbar.

theduckylittle changed the title ~~Adding WFS-T editing to GeoMoose~~ WIP: Adding WFS-T editing to GeoMoose Dec 29, 2020

theduckylittle force-pushed the editing-work branch from 0ca74fd to ddf26e6 Compare January 27, 2021 05:32

brentfraser mentioned this pull request Jan 28, 2021

Feature Editing #47

Closed

Base automatically changed from master to main February 5, 2021 21:15

theduckylittle force-pushed the editing-work branch 2 times, most recently from 1cc047b to ea80452 Compare February 8, 2021 02:11

theduckylittle commented Feb 8, 2021

View reviewed changes

theduckylittle force-pushed the editing-work branch 2 times, most recently from 8205fb5 to 6129c35 Compare February 12, 2021 03:59

theduckylittle force-pushed the editing-work branch from 29acd5f to 48d7bee Compare February 19, 2021 01:25

theduckylittle mentioned this pull request Feb 24, 2021

Discussion: Updating Examples to Add Editing #631

Closed

theduckylittle force-pushed the editing-work branch from 48d7bee to 8d38682 Compare March 14, 2021 15:13

theduckylittle changed the title ~~WIP: Adding WFS-T editing to GeoMoose~~ Adding WFS-T editing to GeoMoose Mar 15, 2021

klassenjs requested changes Mar 16, 2021

View reviewed changes

examples/desktop/app.js Outdated Show resolved Hide resolved

tests/gm3/reducers/editor.test.js Show resolved Hide resolved

theduckylittle force-pushed the editing-work branch from 1075283 to b92747f Compare March 17, 2021 02:56

klassenjs approved these changes Mar 17, 2021

View reviewed changes

theduckylittle added 22 commits March 17, 2021 07:20

Add forced reload for vector layers and minor clean ups

d0fc662

Fix bug with multipolgon points not display in edit.

bf0d434

Zoom tools are now react components

3d6c6ac

Support alternate projections for WFS-T posts.

ca75a85

Fix catalog tests missing the query tree

1d1deef

lower tab toggler under modals

6835fef

re-enable proj

40ed366

Fix bug with remove-feature showing dialog with no feature selected.

a922592

Make the properties mix in safer when setting boundedBy

eacd51b

Add new "query-as" attribute to allow WMS display and WFS editing

95a0650

Add support for inserting features over WFS-T

b9d12c1

Add delete, centralize editing logic, add editing mapbook.

67cea04

Add a deletion confirmation modal

1412715

Clean up layer rendering, add landmarks example, add point buffering …

282a959

…for point layer query

UX improvements for tools in catalog and toolbar

46fc827

1. Add affordances to selected tools in the catalog. 2. Add signifiers to selected services in the toolbar.

when starting a drawing, close the old service.

821bb38

Shift the modals to the map component so they work in all catalog views

29cdf39

shorten full extent tool label

c181231

Open the properties modal when adding a feature

7326049

Default values only fill in for new features.

aa3366b

Fix queryAs bug (when undefined), remove editing from app.js

8797a83

theduckylittle force-pushed the editing-work branch from b92747f to 8797a83 Compare March 17, 2021 12:23

theduckylittle merged commit 971cd06 into geomoose:main Mar 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding WFS-T editing to GeoMoose #620

Adding WFS-T editing to GeoMoose #620

theduckylittle commented Dec 29, 2020

theduckylittle Feb 8, 2021

brentfraser Feb 10, 2021 •

edited

Loading

brentfraser commented Feb 27, 2021 •

edited

Loading

brentfraser commented Feb 27, 2021 •

edited

Loading

brentfraser commented Mar 3, 2021

brentfraser commented Mar 3, 2021

brentfraser commented Mar 3, 2021 •

edited

Loading

theduckylittle commented Mar 14, 2021

brentfraser commented Mar 14, 2021

brentfraser commented Mar 15, 2021

theduckylittle commented Mar 15, 2021

brentfraser commented Mar 15, 2021

theduckylittle commented Mar 15, 2021

klassenjs left a comment

klassenjs commented Mar 16, 2021 •

edited

Loading

klassenjs commented Mar 16, 2021

klassenjs commented Mar 16, 2021

Adding WFS-T editing to GeoMoose #620

Adding WFS-T editing to GeoMoose #620

Conversation

theduckylittle commented Dec 29, 2020

theduckylittle Feb 8, 2021

Choose a reason for hiding this comment

brentfraser Feb 10, 2021 • edited Loading

Choose a reason for hiding this comment

brentfraser commented Feb 27, 2021 • edited Loading

brentfraser commented Feb 27, 2021 • edited Loading

brentfraser commented Mar 3, 2021

brentfraser commented Mar 3, 2021

brentfraser commented Mar 3, 2021 • edited Loading

theduckylittle commented Mar 14, 2021

brentfraser commented Mar 14, 2021

brentfraser commented Mar 15, 2021

theduckylittle commented Mar 15, 2021

brentfraser commented Mar 15, 2021

theduckylittle commented Mar 15, 2021

klassenjs left a comment

Choose a reason for hiding this comment

klassenjs commented Mar 16, 2021 • edited Loading

klassenjs commented Mar 16, 2021

klassenjs commented Mar 16, 2021

brentfraser Feb 10, 2021 •

edited

Loading

brentfraser commented Feb 27, 2021 •

edited

Loading

brentfraser commented Feb 27, 2021 •

edited

Loading

brentfraser commented Mar 3, 2021 •

edited

Loading

klassenjs commented Mar 16, 2021 •

edited

Loading