User Feedback / Add possibility to customize rating criterias (from DB) & other improvements #2712
Conversation
…B) & other improvements List of evaluation criteria is not limited to 5 hardcoded ones. * Enable advanced feedback mode by default * Add criteria details in full view page * Same comment layout in record view and all feebacks view * Add gravatar for users (like other pages) * Do not show see all feedbacks if no feedbacks * Display average score only when at least once is set * Feedback date is a ISODate instead of Date like all other dates * Metadata title has to be handle by client side not part of a feedback (this remove dependency to ISO19139 only records) * Cleanup unused code about Other category
| @@ -45,144 +55,46 @@ | |||
| */ | |||
| public class RatingAverage { | |||
|
|
|||
| /** The metadata title. */ | |||
| private String metadataTitle; | |||
There was a problem hiding this comment.
Without the title on the home page there is no reference to the record
There was a problem hiding this comment.
True so I will restore that but do not rely on 19139 xpath
| @@ -45,144 +55,46 @@ | |||
| */ | |||
| public class RatingAverage { | |||
|
|
|||
| /** The metadata title. */ | |||
| private String metadataTitle; | |||
| Log.debug("org.fao.geonet.api.userfeedback.UserFeedback", "newUserFeedback"); | ||
|
|
||
| final IUserFeedbackService userFeedbackService = getUserFeedbackService(); | ||
|
|
||
| boolean recaptchaEnabled = settingManager.getValueAsBool(Settings.SYSTEM_USERSELFREGISTRATION_RECAPTCHA_ENABLE); |
There was a problem hiding this comment.
With the recaptcha the check is done even if the option is not activated. I got this error on javascript console:
Error: No reCAPTCHA clients exist. Nr@https://www.gstatic.com/recaptcha/api2/v1524685466525/recaptcha__en.js:406:411 Pr@https://www.gstatic.com/recaptcha/api2/v1524685466525/recaptcha__en.js:405:62 reload@http://localhost:8080/geonetwork/static/lib3d.js:153714:1732 link/c.submitForm/<@http://localhost:8080/geonetwork/static/gn_search_default.js:999:390 m/h.success/<@http://localhost:8080/geonetwork/static/lib3d.js:641:436 e/<@http://localhost:8080/geonetwork/static/lib3d.js:675:69 $eval@http://localhost:8080/geonetwork/static/lib3d.js:689:269 $digest@http://localhost:8080/geonetwork/static/lib3d.js:686:361 $apply@http://localhost:8080/geonetwork/static/lib3d.js:690:33
|
Tested and looks fine, some minor stuff to check, but can be done later. Going to merge the PR.
|
List of evaluation criteria is not limited to 5 hardcoded ones.
Example with custom criteria
Related to #2419