-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFS indexing / Align with sextant #3205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification around ac049ee are needed in my opinion.
...harvester/src/main/java/org/fao/geonet/harvester/wfsfeatures/worker/EsWFSFeatureIndexer.java
Show resolved
Hide resolved
...harvester/src/main/java/org/fao/geonet/harvester/wfsfeatures/worker/EsWFSFeatureIndexer.java
Show resolved
Hide resolved
...harvester/src/main/java/org/fao/geonet/harvester/wfsfeatures/worker/EsWFSFeatureIndexer.java
Outdated
Show resolved
Hide resolved
I'll take a look ASAP. Basically we want the files to be the same as in sextant, which is where most of the WFS filter/indexing work was done, right? |
Yep. |
workarounds refine error messaging when report saved do not go further when failure at es report initialisation time infer wfs version from geotools sources rather than from parameters default to GML3 for datasources, not taken into account when wfs 1.0.0 leverage wfs datasources timeout to 3000s
… of the default 4 applies by GeometryJSON) and optionnaly apply a precision model to reduce the geometry complexity and avoid to build invalid geometry when removing decimals. This may create a simplified geometry above the equivalent displayed in WMS. Set those values depending on the WFS harvested.
…operty file on startup. Not filtered on build.
…S 6.4.x needs to be URL encoded.
This was introduced by https://github.com/camptocamp/sextant-geonetwork/commit/e5ede11b419e4f0fcc0bf8c4e420aabb9dd8ff60 featureAttributeToDocumentFieldNames was shared in a EsWFSFeatureIndexer singleton. Changing scope to prototype to have one instance on each harvest.
…d to (probably fixed in?) Sextant.
* Add support for index type * Limit proxy to the index we are using (and not all the ES cluster) * WFS indexing / Add support for CDATA
1fbbd5c
to
d94d719
Compare
Filtering is done by adding an 'include' criteria on the bucket aggregation for the facet.
+ fix to labels for fields only in app profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've added a few commits that I felt were missing but nothing much. Thanks
Related to #3205 which now encode URL and feature type name to support ES 6.4+ and to point to the correct index containing features (and not to the ES cluster root only).
Related to #3205 which now encode URL and feature type name to support ES 6.4+ and to point to the correct index containing features (and not to the ES cluster root only).
Changes:
Those changes are backported from Ifremer Sextant.
Future tasks: