Add inline messages for the Add Feedback form #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichelGabriel something I notice, that should not be related to the PR is that the form doesn't detect that the user is logged. I'm logged as
That can be done in a separate PR. In GeoNetwork 3 it works fine. |
josegar74
added a commit
to GeoCat/core-geonetwork
that referenced
this pull request
Jun 7, 2022
…ude unrequired fields when the user is logged. Hiding the fields trigger the validation, it is required to use data-ng-if directive instead of data-ng-hide
josegar74
added a commit
that referenced
this pull request
Jun 7, 2022
…ired fields when the user is logged. Hiding the fields trigger the validation, it is required to use data-ng-if directive instead of data-ng-hide (#6346)
josegar74
added a commit
that referenced
this pull request
Jun 7, 2022
* Add inline messages for the add feedback form * Fix path for angular-messages.min.js Co-authored-by: Jose García <josegar74@gmail.com>
josegar74
added a commit
that referenced
this pull request
Jun 7, 2022
…nrequired fields when the user is logged. Hiding the fields trigger the validation, it is required to use data-ng-if directive instead of data-ng-hide (#6346)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the messages when adding new feedback by using
ngMessages. Messages are shown inline, and theSaveis enabled when everything is valid.An additional check is done on the 'review' input, a check on the maximum characters.