Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation build updates #140

Closed
wants to merge 4 commits into from
Closed

documentation build updates #140

wants to merge 4 commits into from

Conversation

jodygarnett
Copy link
Contributor

  • update readme to reflect build steps
  • add ccbya license to pom and repository to reflect footer used in docs
  • consistently build english and french as the default
  • seperate properties for translations to download, and languages to build
  • all profile is now only responsible for defining translations to download and langues to build

Signed-off-by: Jody Garnett jody.garnett@gmail.com

@jodygarnett
documentation build updates
5b10ce3 
* update readme to reflect build steps
* add ccbya license to pom and repository to reflect footer used in docs
* consistently build english and french as the default
* seperate properties for translations to download, and languages to build
* all profile is now only responsible for defining translations to download and langues to build

Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
jodygarnett
jodygarnett commented May 19, 2020
View reviewed changes
Makefile Show resolved Hide resolved
@jodygarnett
Remove unused _build/locale folder
9b862b3 
This appears to be accidentially committed some years ago

Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
@jodygarnett
messed up quotes on default translations list to download
ffc5b1d 
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
@jodygarnett
disable colored output for build server
fae6be6 
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
juanluisrp
juanluisrp requested changes May 20, 2020
View reviewed changes
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
juanluisrp added a commit that referenced this pull request May 21, 2020
@juanluisrp
Documentation build updates (#140)
07beec0 
    * Update readme to reflect build steps
    * Add ccbya license to pom and repository to reflect footer used in docs
    * Consistently build english and french as the default
    * Seperate properties for translations to download, and languages to build
    * All profile is now only responsible for defining translations to download and langues to build
    * Disable colored output for build server
    * Remove unused _build/locale folder
    * Ignore Visual Studio Code and DS_Store files

    Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
@juanluisrp
Copy link
Contributor

Manually merged in 07beec0 commit

@juanluisrp juanluisrp closed this May 21, 2020
juanluisrp added a commit that referenced this pull request May 21, 2020
@juanluisrp
Documentation build updates (#140)
bf333fe 
    * Update readme to reflect build steps
    * Add ccbya license to pom and repository to reflect footer used in docs
    * Consistently build english and french as the default
    * Seperate properties for translations to download, and languages to build
    * All profile is now only responsible for defining translations to download and langues to build
    * Disable colored output for build server
    * Remove unused _build/locale folder
    * Ignore Visual Studio Code and DS_Store files

    Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
@fxprunayre
Copy link
Member

It looks like transifex is complaining

image

https://raw.githubusercontent.com/geonetwork/doc/develop/_build/locale/annexes/mef-format.pot
returns 404.

Not sure how we could improve doc translation management but currently it looks like English pot files are used.

@jodygarnett
Copy link
Contributor Author

How does this interaction work @fxprunayre?

Was the _build folder being used by transifex? If so we had a workflow issue as the contents of that folder had not been updated for ... 3 years.

@fxprunayre
Copy link
Member

Was the _build folder being used by transifex? If so we had a workflow issue as the contents of that folder had not been updated for ... 3 years.

Maybe something to ask to Maria ;) We only noticed that in last November doc sprint #82 and discussed a bit but with no easy workaround/solutions for this. From my point of view, translating line by line the doc in transifex does not look to be a good idea (but I'm not a transifex guru). Translating on github sounds much easier from a maintenance point of view even if it is maybe a bit more complex for translators? Would maybe need to be able to display 2 languages side by side ... So something to improve...

@fxprunayre
Copy link
Member

r had not been updated for ... 3 years.

One issue it that if you update the source file, then if we changed the english text, then transifex will cancel all existing translations - not tested but it is how it works for the json files... so I would be cautious updating that. At least it needs a test.

@jodygarnett
Copy link
Contributor Author

Perhaps this change to remove _build contents should be reverted, glad it was as a separate commit.

@jodygarnett jodygarnett deleted the doc_updates branch May 22, 2020 21:32
@juanluisrp juanluisrp mentioned this pull request Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisrp juanluisrp juanluisrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jodygarnett @juanluisrp @fxprunayre