Comment (nearly) all properties in properties files #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #129 Please review with care (with the work on #2496, all properties should use their default value in case the property had not been set in datadir, but...) |
severo
changed the title
16 tasks
|
I like it, it will clearly show what has been modified from the defaults - even if i'll have to remerge all the config changes for the ansible playbook, it'll be nicer in the end :) |
|
Excellent... It's good to have the feedback from you since you are managing an instance... As I wrote in the issue, I had the same appreciation when I managed one, it should be easier for the administrators. |
|
Wow, this is really excellent Sylvain. Please rebase before merge. |
Since a default value is set in the geOrchestra code when any property is loaded from a properties file, it's not necessary to provide it also in the datadir properties files, unless it is different from the default. It also makes it easier for the instance administrator to review their datadir, focusing only on important properties, and letting the default values unchanged for the rest of the properties. See #129 for the motivation. Note that the default.properties file has been let uncommented, as we always want these values to be set by the instance administrator.
|
There is some more work due to the commits meanwhile. |
fvanderbiest
approved these changes
Mar 20, 2019
This was referenced Mar 20, 2019
fvanderbiest
pushed a commit
to georchestra/extractorapp
that referenced
this pull request
Apr 2, 2023
It's required because all the application properties will be commented by default in the datadir. See georchestra/datadir#137 and georchestra/datadir#138.
fvanderbiest
pushed a commit
to georchestra/atlas
that referenced
this pull request
Apr 2, 2023
It's required because all the application properties will be commented by default in the datadir. See georchestra/datadir#137 and georchestra/datadir#138.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a default value is set in the geOrchestra code when any property
is loaded from a properties file, it's not necessary to provide it also
in the datadir properties files, unless it is different from the default.
It also makes it easier for the instance administrator to review their
datadir, focusing only on important properties, and letting the default
values unchanged for the rest of the properties.
See #129 for the
motivation.
Note that the default.properties file has been let uncommented, as we
always want these values to be set by the instance administrator.