-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework update repository to getML version 1.4.0 #17
Conversation
Urfoex
commented
Feb 14, 2024
- Update notebooks to work with current versions of getML, featuretools, tsfresh, prophet ...
- Clean up contents of notebooks
- Add docker and compose files for easy local testing
- Add requirements with pinned versions for Python 3.8 and 3.11
- move binder to own project
…2 #33 #34 #36 #37 #38 #39 #40 Updated and cleaned-up notebooks using woodwork-types to fit getml and table description update adventure_works air_pollution atherosclerosis baseball cora consumer_expenditures dodgers formula1 imdb interstate94 loans movie_lens occupancy online_retail robot seznam sfscores stats update fastprop_benchmark: air_pollution dodgers interstate94 occupancy robot added Dockerfile, docker-compose.yml, and README.md on how to use them added requirements.txt for usage with python3.8 and python3.11 rename propositionalization to fastprop_benchmark move binder into own project adjusting colors
f208b78
to
13d2fd2
Compare
…2 #33 #34 #36 #37 #38 #39 #40 Updated and cleaned-up notebooks using woodwork-types to fit getml and table description update adventure_works air_pollution atherosclerosis baseball cora consumer_expenditures dodgers formula1 imdb interstate94 loans movie_lens occupancy online_retail robot seznam sfscores stats update fastprop_benchmark: air_pollution dodgers interstate94 occupancy robot added Dockerfile, docker-compose.yml, and README.md on how to use them added requirements.txt for usage with python3.8 and python3.11 rename propositionalization to fastprop_benchmark move binder into own project adjusting colors adjust readme.md and welcome.md to reflect changes repository
13d2fd2
to
7f26ae2
Compare
…2 #33 #34 #36 #37 #38 #39 #40 Updated and cleaned-up notebooks using woodwork-types to fit getml and table description update adventure_works air_pollution atherosclerosis baseball cora consumer_expenditures dodgers formula1 imdb interstate94 loans movie_lens occupancy online_retail robot seznam sfscores stats update fastprop_benchmark: air_pollution dodgers interstate94 occupancy robot added Dockerfile, docker-compose.yml, and README.md on how to use them added requirements.txt for usage with python3.8 and python3.11 rename propositionalization to fastprop_benchmark move binder into own project adjusting colors adjust readme.md and welcome.md to reflect changes repository simplify dockerfile add basic binder requirements
7f26ae2
to
aae50de
Compare
&4 #16 #17 #18 #19 #20 #21 #22 #23 #24 #25 #26 #27 #28 #29 #30 #31 #32 #33 #34 #36 #37 #38 #39 #40 related issues using woodwork-types to fit getml and table description update adventure_works air_pollution atherosclerosis baseball cora consumer_expenditures dodgers formula1 imdb interstate94 loans movie_lens occupancy online_retail robot seznam sfscores stats update fastprop_benchmark: air_pollution dodgers interstate94 occupancy robot added Dockerfile, docker-compose.yml, and README.md on how to use them added requirements.txt for usage with python3.8 and python3.11 rename propositionalization to fastprop_benchmark move binder into own project adjusting colors adjust readme.md and welcome.md to reflect changes repository simplify dockerfile add basic binder requirements
aae50de
to
11a4d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you so much for the effort!
Thank you, this looks great. I have some questions,but as there are so many changes and I’m on mobile I cannot comment inline, sorry.
|
3.8 is the minimum version, and 3.11 the current maximum. 3.11 supports a few newer libraries. And with upcoming changes, support for newer versions, we can quickly start and test them.
That is about 460MB. (https://quay.io/repository/pypa/manylinux2014_x86_64?tab=tags&tag=latest)
There is also Jupyter-Lab, getML engne, getML monitor running inside. I would need to try, if they still work in the slim one. (A quick runs in problems with missing curl and can't apt install it… And pysimdjson fails with Okay, on disk it is more like 1.56 GB. Because of PEP513... PEP600... , manylinux sounded like a good base. |
Why the merge? I think there were some points still open. Also, I think we agreed that a merge is carried out only by PRs‘ owners after approval. Please guys, refrain from merging other’s PRs. |
Let's turn that last open question into an issue and sorry for pushing, but I don't see how this review of a rather small issue will be concluded in time for this Mondays demo. Having the main branch still on version 1.3.2, a commit from over a year ago, gives an impression that does not do justice to all the work we have put into this. And of course, I agree on the matter of the issue: we do not necessarily need two separate docker files, especially versions that diverge with the files in getml-community, and on top that only run on linux/x64. |