Skip to content

Conversation

Urfoex
Copy link
Contributor

@Urfoex Urfoex commented Feb 26, 2024

epic &4
issue #35

@Urfoex Urfoex added the enhancement New feature or request label Feb 26, 2024
@Urfoex
Copy link
Contributor Author

Urfoex commented Feb 26, 2024

Do we still need the WELCOME.md? @alxn4 @getml/all

@Urfoex Urfoex force-pushed the update_readme_1_4_0 branch from 982e545 to a5310e3 Compare February 27, 2024 10:38
@Urfoex Urfoex marked this pull request as ready for review February 27, 2024 10:48
@Urfoex Urfoex force-pushed the update_readme_1_4_0 branch from a5310e3 to 508aaac Compare February 28, 2024 00:05
@Urfoex
Copy link
Contributor Author

Urfoex commented Feb 28, 2024

Do we still need the WELCOME.md? @alxn4 @getml/all

Removed together with binder, as it is just partly working.

@liuzicheng1987
Copy link
Contributor

Why are we using podman here? I think Docker is the standard here and using a tool that many people have never heard of will make adoption harder.

@Urfoex
Copy link
Contributor Author

Urfoex commented Feb 28, 2024

Why are we using podman here? I think Docker is the standard here and using a tool that many people have never heard of will make adoption harder.

Podman is a mostly hazel-free drop-in replacement for Docker. Because of its higher security, it is included in Redhat since version RHEL 8:

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/8.0_release_notes/notable_changes_to_containers

https://www.heise.de/news/Red-Hat-Enterprise-Linux-8-freigeben-Mehr-Flexibilitaet-bei-Software-Versionen-4416725.html#nav_container_im__3

Not to mention: companies with more then 250 people and Mac and Windows users probably evaluated alternatives like Podman-Desktop and Rancher-Desktop because of:
"Commercial use of Docker Desktop at a company of more than 250 employees OR more than $10 million in annual revenue requires a paid subscription (Pro, Team, or Business)." (https://www.docker.com/products/docker-desktop/)

Define "many people".
https://github.com/containers/podman has 21K Stars.

While the docker open source part seems to be now moby
https://stackoverflow.com/questions/47793812/where-is-the-docker-source-code-located-github-repo
https://github.com/moby/moby
with 67K stars.

"Docker being the standard" for what?
The container world is much bigger.
https://en.wikipedia.org/wiki/List_of_cluster_management_software
https://en.wikipedia.org/wiki/OS-level_virtualization

For simple users trying the notebooks it would be nicer to have a full ready image on a registry.
It seems, there is a getml account;
https://hub.docker.com/u/getml
It would be nicer, to have a full image with notebook and engine on their and ready to run, instead of having the user to build it.
Or on another registry, like

  • quay.io (redhat)
    
  • gcr.io (google)
    
  • public.ecr.aws (amazon)
    
  • ghcr.io (github)
    
  • ...
    

Or simply download the notebooks and run them locally inside their Jupyer-Lab.

Not to mention, podman is a drop-in replacement for docker.
In the repository, there is still just Dockerfile and docker-compose.yml. Just making sure, that the software and libraries inside are provided and run-able as user and not as root.
There is no extra adoption needed. Just reaching a wider audience.

@srnnkls
Copy link
Collaborator

srnnkls commented Feb 29, 2024

Thank you @Urfoex. While I agree with everything you said, I would argue many people – in particular in the data science community – are not familiar with the nuances of Linux containerization. As docker is the best known implementation, we should use that throughout the examples. If you like, maybe, you can reference podman (like you have done in the root-level README).

@Urfoex Urfoex force-pushed the update_readme_1_4_0 branch from 508aaac to db4207f Compare February 29, 2024 08:13
@Urfoex
Copy link
Contributor Author

Urfoex commented Feb 29, 2024

Oh, in the docker/README.md. Sorry, I missed that part.
Adjusted.

alxn4 pushed a commit that referenced this pull request Mar 2, 2024
- Update notebooks to work with current versions of getML, featuretools, tsfresh, prophet ...
- Clean up contents of notebooks
- Add docker and compose files for easy local testing
- Add requirements with pinned versions for Python 3.8 and 3.11
- Move binder to own project

&4 #16 #17 #18 #19 #20 #21 #22 #23 #24 #25 #26 #27 #28 #29 #30 #31 #32 #33 #34 #36 #37 #38 #39 #40 related issues
@alxn4 alxn4 changed the base branch from rework_update_repository_1_4_0 to 1.4.0 March 2, 2024 19:05
@alxn4 alxn4 changed the base branch from 1.4.0 to rework_update_repository_1_4_0 March 2, 2024 19:08
@Urfoex Urfoex force-pushed the update_readme_1_4_0 branch from db4207f to 3e3d094 Compare March 3, 2024 19:54
@Urfoex Urfoex changed the base branch from rework_update_repository_1_4_0 to master March 3, 2024 19:59
@alxn4 alxn4 merged commit a3f9062 into master Mar 4, 2024
@Urfoex Urfoex deleted the update_readme_1_4_0 branch March 4, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants