-
Notifications
You must be signed in to change notification settings - Fork 8
update README: Adding ToC, how to use the notebooks, descriptions. Little cleanup #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we still need the WELCOME.md? @alxn4 @getml/all |
982e545
to
a5310e3
Compare
a5310e3
to
508aaac
Compare
Removed together with binder, as it is just partly working. |
Why are we using podman here? I think Docker is the standard here and using a tool that many people have never heard of will make adoption harder. |
Podman is a mostly hazel-free drop-in replacement for Docker. Because of its higher security, it is included in Redhat since version RHEL 8: Not to mention: companies with more then 250 people and Mac and Windows users probably evaluated alternatives like Podman-Desktop and Rancher-Desktop because of: Define "many people". While the docker open source part seems to be now moby "Docker being the standard" for what? For simple users trying the notebooks it would be nicer to have a full ready image on a registry.
Or simply download the notebooks and run them locally inside their Jupyer-Lab. Not to mention, podman is a drop-in replacement for docker. |
Thank you @Urfoex. While I agree with everything you said, I would argue many people – in particular in the data science community – are not familiar with the nuances of Linux containerization. As docker is the best known implementation, we should use that throughout the examples. If you like, maybe, you can reference podman (like you have done in the root-level README). |
508aaac
to
db4207f
Compare
Oh, in the docker/README.md. Sorry, I missed that part. |
- Update notebooks to work with current versions of getML, featuretools, tsfresh, prophet ... - Clean up contents of notebooks - Add docker and compose files for easy local testing - Add requirements with pinned versions for Python 3.8 and 3.11 - Move binder to own project &4 #16 #17 #18 #19 #20 #21 #22 #23 #24 #25 #26 #27 #28 #29 #30 #31 #32 #33 #34 #36 #37 #38 #39 #40 related issues
…ttle cleanup. Remove binder. epic &4 issue #35
db4207f
to
3e3d094
Compare
epic &4
issue #35