JSON Data Source #3805
JSON Data Source #3805
Conversation
|
Hello. When is this likely to be available in the preview docker containers? Thanks. |
|
Fantastic, and thanks for your efforts on this! We're just now switching over to a more heavily REST-oriented approach, so this will be most helpful. Please keep us apprised, and if I can help with some testing or the like, I'd be happy to do so (at least as best I can; we're swamped laying down an entirely new software infrastructure). |
|
I understand you all are busy building, would it be possible to provide instructions for how to build this PR into a docker image so that it can be tested? I attempted to deploy a version of redash from the docs with docker, however I ran into a few issues getting things to run nicely. I.E webpack, etc. |
|
Just stopping by to see if there is an update on the docker preview build. |
|
Hi everyone, Tried to build docker image locally, but i can't view/use the current json datasources. Is there something i miss about it, or maybe it's not functionnal now ? Thanks. |
| if 'url' not in query: | ||
| raise QueryParseError("Query must include 'url' option.") | ||
|
|
||
| if is_private_address(query['url']): |
There was a problem hiding this comment.
Why should we avoid querying private url/ip ?
There was a problem hiding this comment.
Because in some environments being able to query private addresses might allow you to poke around things you shouldn't (like AWS metadata of the instance hosting Redash). We can make this optional if needed.
There was a problem hiding this comment.
I think it's a good idea to have an option to disable it
* WIP: JSON Data Source * Add JSON data source to default list
* WIP: JSON Data Source * Add JSON data source to default list
What type of PR is this? (check all applicable)
Description
JSON data source, which allows loading data from (almost) any JSON URL (Documentation).
TODO:
- [ ] Rename it toHTTP(?).- [ ] Migration to update the type of existing URL data sources to use this one.- [ ] Migration to update existing queries to support the new format.- [ ] Remove URL data source.I figured there is no point in waiting to deprecate the URL data source and delaying the release of this one. We will do it in a separate task.
Related Tickets & Documents
https://discuss.redash.io/t/missing-json-data-source/3448/22