Skip to content

Conversation

szokeasaurusrex
Copy link
Member

We have been generating these error messages, but we never print them, even though it seems like we probably mean to be printing them.

Fixes #2774
Fixes CLI-170

@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner September 19, 2025 15:23
Copy link

linear bot commented Sep 19, 2025

@szokeasaurusrex szokeasaurusrex marked this pull request as draft September 19, 2025 15:25
cursor[bot]

This comment was marked as outdated.

We have been generating these error messages, but we never print them, even though it seems like we probably mean to be printing them.

Fixes #2774
Fixes [CLI-170](https://linear.app/getsentry/issue/CLI-170/sourcemap-injection-errors-never-displayed)
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/errors-sourcemap-inject branch from eead738 to 09e715a Compare September 19, 2025 15:40
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review September 19, 2025 15:41
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, seems useful to print the errors.
I wonder, does the user know what do to in order to resolve the issue? Would it make sense to display some more info about the issue and/or how to resolve it?
Or is it something that CLI will be able to fix on its own?
Or another possibility, is this just warnings that we want to see for bug reports?

@szokeasaurusrex
Copy link
Member Author

@lcian I guess we will see whether users are able to figure out what to do based on the error message. To be honest, I am not completely sure whether they will be able to figure it out. But, we can see and adjust the messages if they are too confusing for users.

In any case, it definitely seems like a bug that these messages were not being displayed.

@szokeasaurusrex szokeasaurusrex merged commit f07b24e into master Sep 22, 2025
25 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/errors-sourcemap-inject branch September 22, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcemap injection errors never displayed
2 participants