-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(replay): session replay updates to add AI summary for web #14794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 12.39kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
<Alert> | ||
|
||
* **Console:** A list of debugging messages that don't belong in the breadcrumbs list will appear here. For web, this includes `console.log` statements and browser-generated messages to the developer. For React Native, custom `console.log` will appear here, and in Android, logs from [Logcat](/platforms/android/integrations/logcat/) and [Timber](/platforms/android/integrations/timber/) are also supported. | ||
By default, the Session Replay SDK is configured to redact all text, user input, and media elements. See all privacy configuration options [here](/platform-redirect/?next=/session-replay/privacy/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This platform-redirect link is missing so many platforms, for example, all of the JS frameworks have their own Privacy page (e.g., Angular) - I'm not sure why that is :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it. Probably start a different PR to fix that page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I did some digging, and the reason why it's not rendering all the JS frameworks is because they all are proxied from the one common
privacy page under JS. Because of that, it's tricky to have all of them listed on the /platform-redirect/?next=/session-replay/privacy/
page. I reformatted the platform redirect pages to pull in all the JS frameworks in the list, so they should now all show up across any /platform-redirect/
page.
I also found that there was insufficient logic to pull in Dart because it was nested under guide
, and we were only checking for top level platforms. Both use cases will now be fixed. PR: #14914
I've asked @Jesse-Box to help with a new image asset for the Replay Details page so we can show off the AI summary. Using the Sentry colour palette for this would be nice, and so it can be consistent with the other visuals in the Replay product docs Let's also update the second image on this page Edit: @michellewzhang can help out here on visuals! 😄 |
a315080
to
0099671
Compare
This comment was marked as outdated.
This comment was marked as outdated.
assets have been updated here: https://www.figma.com/design/NNLgAJyzZno8NrBuJPVFQi/Assets--Product-Docs-v2--Copy-?node-id=3401-71&t=GxLKZGqTmNJDGh7V-0 (i had to create a copy of the original file since i didn't have edit access). all replay images have been updated in this pr (excluding mobile images, since we are hiding ai tab on mobile replays for now). |
@michellewzhang assets look great! ✨ still seeing the old images on the latest vercel preview https://sentry-docs-ewbq8pkob.sentry.dev/product/explore/session-replay/web/ despite your update 🤔 , not sure why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big lift, looks good! 🏄♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3 latest changes look good, thanks @sfanahata!
@jas-kas and @michellewzhang - I've updated with all the suggestions, except updating the privacy page, which I'll take on in a different PR shortly. LMK if there's anything more I can help with here. I'll keep this one hanging out until we're ready to release the feature. |
Waiting to merge when officially goes open beta
closes https://linear.app/getsentry/issue/REPLAY-528/add-docs
DESCRIBE YOUR PR
Updating the replay details and web replay pages to add in AI summaries info.
Details page: https://sentry-docs-git-session-replay-ai-summary-ea.sentry.dev/product/explore/session-replay/replay-details/
Replay for web: https://sentry-docs-git-session-replay-ai-summary-ea.sentry.dev/product/explore/session-replay/web/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: