-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(replay): session replay updates to add AI summary for web #14794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d471632
session replay updates for AI summary for web
90c92fd
updates to web doc
8311abd
small fixes
8959d2a
changing from EA to open beta
0099671
update images
michellewzhang 2b732f6
update path
michellewzhang f7f27e7
add back tags img
michellewzhang 249f3fd
refining and pushing updates for a new build
94e286e
trying to clear the vercel cache
6c951d0
forcing vercel to clear cache
7f2fc30
incorporating feedback
b767ebd
updating feature bullet
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+124 KB
(170%)
docs/product/explore/session-replay/img/replay-details-share.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+153 KB
(190%)
docs/product/explore/session-replay/img/replay-details-tags.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+220 KB
(230%)
docs/product/explore/session-replay/img/replay-index-filtering.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+246 KB
(170%)
docs/product/explore/session-replay/web/img/session-replay-what-is-a-replay.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+67.9 KB
(120%)
docs/product/explore/session-replay/web/img/session-replay.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This platform-redirect link is missing so many platforms, for example, all of the JS frameworks have their own Privacy page (e.g., Angular) - I'm not sure why that is :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it. Probably start a different PR to fix that page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I did some digging, and the reason why it's not rendering all the JS frameworks is because they all are proxied from the one
common
privacy page under JS. Because of that, it's tricky to have all of them listed on the/platform-redirect/?next=/session-replay/privacy/
page. I reformatted the platform redirect pages to pull in all the JS frameworks in the list, so they should now all show up across any/platform-redirect/
page.I also found that there was insufficient logic to pull in Dart because it was nested under
guide
, and we were only checking for top level platforms. Both use cases will now be fixed. PR: #14914