Skip to content

Commit a5af9c8

Browse files
k-fishkamilogorek
andauthored
fix(ember): Fix ember tests on release (#2887)
* fix(ember): Fix ember tests by switching ember-try to yarn Ember-try uses npm to modify the package.json to test different versions of Ember, switching to use yarn should fix the issues it had resolving on new releases * Restored ember tests Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
1 parent 7c14283 commit a5af9c8

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
key: ${{ runner.os }}-${{ github.sha }}
8888
- run: yarn install
8989
- name: Unit Tests
90-
run: yarn test --ignore="@sentry/ember"
90+
run: yarn test
9191
- uses: codecov/codecov-action@v1
9292

9393
job_browserstack_test:

packages/ember/config/ember-try.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ const getChannelURL = require('ember-source-channel-url');
44

55
module.exports = async function() {
66
return {
7+
useYarn: true,
78
scenarios: [
89
{
910
name: 'ember-lts-3.12',

scripts/test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ if [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -le 6 ]]; then
1010
yarn build --ignore="@sentry/ember" --ignore="@sentry/serverless"
1111
nvm use 6
1212
# browser can be tested only on Node >= v8 because Karma is not supporting anything older
13-
yarn test --ignore="@sentry/tracing" --ignore="@sentry/react" --ignore="@sentry/gatsby" --ignore="@sentry/ember" --ignore="@sentry-internal/eslint-plugin-sdk" --ignore="@sentry-internal/eslint-config-sdk" --ignore="@sentry/serverless" --ignore="@sentry/browser" --ignore="@sentry/integrations"
13+
yarn test --ignore="@sentry/tracing" --ignore="@sentry/react" --ignore="@sentry/gatsby" --ignore="@sentry/ember" --ignore="@sentry-internal/eslint-plugin-sdk" --ignore="@sentry-internal/eslint-config-sdk" --ignore="@sentry/serverless" --ignore="@sentry/browser" --ignore="@sentry/integrations"
1414
elif [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -le 8 ]]; then
1515
yarn install --ignore-engines --ignore-scripts
1616
# ember requires Node >= 10 to build
@@ -20,5 +20,5 @@ elif [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -le 8 ]]; then
2020
else
2121
yarn install
2222
yarn build
23-
yarn test --ignore="@sentry/ember"
23+
yarn test
2424
fi

0 commit comments

Comments
 (0)