Latest @sentry/browser asks for node types

[MhMadHamster]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other:

Version:

5.24.2

Description

Latest version of @sentry/browser via dependencies pulls @sentry/hub which requires node types, essentially making @sentry/browser dependent on node types, and that makes little sense to me since i'm using it in browser. For me the culprit is node_modules\@sentry\hub\dist\interfaces.d.ts asking for "domain" module from node types.

[sylvain101010]

Not sure if related, but installing @sentry/browser and @sentry/integrations breaks my VueJS build:

ERROR in /webapp/node_modules/@types/node/ts3.1/globals.d.ts(573,15):
573:15 Interface 'NodeJS.Module' incorrectly extends interface '__WebpackModuleApi.Module'.
  Types of property 'parent' are incompatible.
    Type 'Module | null | undefined' is not assignable to type 'NodeModule | null'.
      Type 'undefined' is not assignable to type 'NodeModule | null'.
    571 |         '.node': (m: Module, filename: string) => any;
    572 |     }
  > 573 |     interface Module {
        |               ^
    574 |         exports: any;
    575 |         require: Require;
    576 |         id: string;

[dleavitt]

Yep, caused by this commit:
7c14283#diff-7845e1ba449e4a817931bf2ee2bd1c9d

Importing "domain" (part of the node stdlib) puts all of node into the ambient context and breaks everyone's browser projects.

This is a very persistent issue with libs that support both node and the browser:

• Suggestion: add excludeTypeRoots to tsconfig microsoft/TypeScript#18588
• Placeholder Type Declarations microsoft/TypeScript#31894
• Typescript - @sentry/utils references node types #2013

[aleclarson]

See #3050 for a fix.