Skip to content

fix: stop using @types/node in @sentry/hub #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2020
Merged

fix: stop using @types/node in @sentry/hub #3050

merged 2 commits into from
Nov 13, 2020

Conversation

aleclarson
Copy link
Contributor

Fixes #2927

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@dashed dashed requested a review from a team November 13, 2020 02:46
This was referenced Nov 13, 2020
Merged
Closed
HazAT
HazAT approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx :)

@HazAT HazAT merged commit ff578c7 into getsentry:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest @sentry/browser asks for node types
2 participants
@aleclarson @HazAT