Skip to content

fix(remix): Move hook checks inside the wrapper component. #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AbhiPrasad merged 1 commit into from
Jul 6, 2022
Merged

fix(remix): Move hook checks inside the wrapper component. #5371

AbhiPrasad merged 1 commit into from
Jul 6, 2022

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jul 6, 2022

withSentryRouteTracing is called on root.tsx which runs before entry.client.tsx (where Sentry.init for browser is called and remixRouterInstrumentation is assigned).

The check if the provided hooks are available was failing silently, and causing withSentryRouteTracing to early return the App unwrapped.

This PR ensures that validation runs on the client side, after entry.client.tsx.

@onurtemizkan onurtemizkan mentioned this pull request Jul 6, 2022
Merged
@onurtemizkan onurtemizkan added this to the Sentry Remix SDK milestone Jul 6, 2022
@onurtemizkan onurtemizkan self-assigned this Jul 6, 2022
@AbhiPrasad AbhiPrasad merged commit 1e3ba37 into master Jul 6, 2022
@AbhiPrasad AbhiPrasad deleted the onur/fix-remix-router-check branch July 6, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@onurtemizkan onurtemizkan

Labels

None yet

Projects

None yet

Milestone

Sentry Remix SDK

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan @AbhiPrasad