Skip to content

feat(replay): try/catch around rrweb function calls #6856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mydea merged 1 commit into from
Jan 23, 2023
Merged

feat(replay): try/catch around rrweb function calls #6856

mydea merged 1 commit into from
Jan 23, 2023

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Jan 18, 2023

There were rare instances where stopping rrweb.record would cause an exception to bubble up from rrweb.

@billyvg billyvg changed the title feat(replay): try/catch around stopRecording feat(replay): try/catch around rrweb function calls Jan 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.83 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.48 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.79 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.22 KB (0%)
@sentry/browser - Webpack (minified) 66.19 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.25 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.48 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.75 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.2 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.92 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.55 KB (+0.01% 🔺)

@mydea mydea marked this pull request as ready for review January 23, 2023 18:55
@billyvg @mydea
feat(replay): try/catch around stopRecording
04ebafc 
There were rare instances where stopping rrweb.record would cause an exception to bubble up from rrweb.
@mydea mydea force-pushed the feat-replay-add-more-try-catch branch from 34c5ed7 to 04ebafc Compare January 23, 2023 18:57
@mydea mydea merged commit 3aed9a7 into master Jan 23, 2023
@mydea mydea deleted the feat-replay-add-more-try-catch branch January 23, 2023 20:26
@Lms24 Lms24 mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg @mydea