-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(sveltekit): Introduce client-side handleError wrapper
#7406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
Lms24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks great! Let's just make sure that the conditional export paths are fine in the tarball, then this is good to 🚀
5e04be9 to
2a9e94b
Compare
|
Currently, This would allow us to filter out, transform and enrich errors in an idiomatic way. export const handleError = sequence(
filterUselessErrors,
addContextOrMetadata,
sentryHandleError,
myCustomHandleError);Would it make sense for you to suggest such a change to the SvelteKit team? I'm open to starting a discussion. I'm not quite sure about the consequences, but it feels like it should be a non-breaking change. |
|
@fjdumont thanks for the suggestion. We're definitely going to consider Feel free to go ahead and open a discussion on the SvelteKit repo 👍 |
ref #7402
Adds a wrapper for the client-side
handleErrorhook.Usage is like the following: