feat(nextjs): Add disableLogger option that automatically tree shakes logger statements
#7908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es logger statements
Contributor
size-limit report 📦
|
Lms24
approved these changes
Apr 20, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Nice, we can do the same thing in SvelteKit! (will add a note to the SDK stretch goals)
Member
|
Also, can/should we do the same for tree-shaking tracing code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just adding a very convenient way of treeshaking the logger we can put into docs snippets and the wizard.