fix(node): Mark stack frames with url protocol as in-app frames

[lforst]

Fixes getsentry/sentry#47444

[Lms24]

Generally, this LGTM but in_app might also be overridden by stack trace processing. Which in turn is also influenced by source maps rewriting through Sentry CLI.

I don't have a lot of context on the original issue but if the source maps were uploaded with the webpack plugin (v1), we recently merged in a fix to Sentry CLI v1 which fixed a source maps rewriting bug for file names starting with webpack://. Perhaps this fixes it.

[lforst]

I don't have a lot of context on the original issue but if the source maps were uploaded with the webpack plugin (v1), we recently merged in a fix to Sentry CLI v1 which fixed a source maps rewriting bug for file names starting with webpack://. Perhaps this fixes it.

Wait, what was that bug again?

[Lms24]

This PR describes the fix. Tbh I'm not sure that this is related as this only surfaced in Angular apps but I guess depending on the webpack config it could emerge in other frameworks/builds as well.

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified)	21.02 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified)	65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)	19.56 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified)	58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified)	21.17 KB (0%)
@sentry/browser - Webpack (minified)	69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified)	21.19 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)	49.09 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)	28.65 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)	26.87 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified)	46.87 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified)	40.67 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)	65.75 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)	58.64 KB (+0.01% 🔺)

[lforst]

This PR describes the fix. Tbh I'm not sure that this is related as this only surfaced in Angular apps but I guess depending on the webpack config it could emerge in other frameworks/builds as well.

@Lms24 ah that looks unrelated. The stack traces look fine, it's just that we mark them as in_app false. Thanks for the heads-up though! :)

[Lms24]

It probably is unrelated. For the sake of completeness, I'm just realizing I didn't explain this properly. Because of the wrong source path caused by the bug I described above, the frames were incorrectly set to in_app: false regardless of if they were (forcefully) set to in_app: true in the code or not. So the SDK value didn't matter because it was overwritten during stracktrace processing based on the incorrectly processed source map.

But yeah, in_app: false in webpack just sounded oddly familiar to me which is why I brought it up. Feel free to merge this :)