Prefer fetch API over XHR #1115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@austinpray I think you accidentally committed some extra files here |
|
Yep you right |
|
Can you remove those redundant files please? |
austinpray
commented
Nov 2, 2017
| } | ||
|
|
||
| opts.onSuccess && opts.onSuccess(); | ||
| })["catch"](function () { |
There was a problem hiding this comment.
if you change })["catch"](function () { to }).catch(function () {
you get an eslint error
|
I got rid of the accidentally added files! Eslint stuff explained inline |
|
Also just now noticing that there are some tests that are failing on travis but not locally |
|
It breaks locally as well: Use |
|
Fixed in #1157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #930
I have confirmed that this works when I hooked up the little app in the example folder to an echo server. Could use some help testing making sure the data is accepted by a real sentry server.