feat: Use Fetch instead of XHR when available #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
approved these changes
Nov 30, 2017
|
Tests are broken in IE10/11 and mobile chrome. I'll fix them before merging. |
mayfield
approved these changes
Nov 30, 2017
This was referenced Nov 30, 2017
| var url = opts.url + '?' + urlencode(opts.auth); | ||
|
|
||
| if (supportsFetch()) { | ||
| return _window |
There was a problem hiding this comment.
@kamilogorek here is an issue - now, if you don't pass { credentials:"include" } (include or same-origin) fetch won't pass cookies. Not passing cookies breaks authorization for hosted servers that requires it :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took best of both worlds from:
and added tests coverage.