ref(v8/replay): Deprecate @sentry/replay exports
#11243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
s1gr1d
changed the title
@sentry/replay exports
lforst
reviewed
Mar 22, 2024
Comment on lines
+10
to
+11
| /** @deprecated Use the export from `@sentry/replay` or from framework-specific SDKs like `@sentry/react` or `@sentry/vue` */ | ||
| export type { ReplayEventType } from './types'; |
There was a problem hiding this comment.
Do JSDoc comments work like this? I think we need to add the comments to the actual declarations of the exported items.
There was a problem hiding this comment.
That's true! I fixed it in #11242 by exporting an internal variable that can be re-exported from @sentry/browser and also exporting the deprecated value.
There was a problem hiding this comment.
This made me think. We don't have to deprecate anything in v8. We can just remove it.
s1gr1d
added a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #11200
on v7 #11242