Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(v7/replay): Deprecate @sentry/replay exports #11242

Merged
merged 6 commits into from
Mar 22, 2024
Merged

ref(v7/replay): Deprecate @sentry/replay exports #11242

merged 6 commits into from
Mar 22, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Mar 22, 2024 •
edited

ref #11200
ref issue #8864

@s1gr1d s1gr1d requested a review from Lms24 March 22, 2024 09:11
@s1gr1d s1gr1d changed the title ref(replay): Deprecate @sentry/replay exports ref(v7/replay): Deprecate @sentry/replay exports Mar 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.45 KB (+0.27% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.47 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.47 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.1 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.4 KB (+0.36% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.29 KB (+0.33% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.49 KB (-0.01% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.5 KB (0%)
@sentry/browser - Webpack (gzipped) 22.74 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.55 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.97 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.77 KB (+0.37% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.29 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.1 KB (+0.41% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 38.99 KB (+0.34% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 71.96 KB (+0.2% 🔺)
@sentry/react - Webpack (gzipped) 22.77 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.81 KB (+0.16% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.95 KB (+0.23% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.28 KB (0%)

@s1gr1d s1gr1d mentioned this pull request Mar 22, 2024
Closed
@s1gr1d s1gr1d requested a review from lforst March 22, 2024 09:20
@lforst
Copy link
Member

lforst commented Mar 22, 2024

Same concern as in #11243 (comment)

Lms24
Lms24 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@s1gr1d s1gr1d enabled auto-merge (squash) March 22, 2024 12:56
@s1gr1d s1gr1d self-assigned this Mar 22, 2024
@s1gr1d s1gr1d merged commit ef37773 into v7 Mar 22, 2024
90 checks passed
@s1gr1d s1gr1d deleted the sig-deprecate-replay branch March 22, 2024 14:19
@Lms24 Lms24 mentioned this pull request Apr 10, 2024
Merged
@Lms24 Lms24 mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@s1gr1d s1gr1d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s1gr1d @lforst @Lms24