Skip to content

Support for fetch for _makeRequest #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Support for fetch for _makeRequest #1156

wants to merge 2 commits into from

Conversation

mayfield
Copy link

No description provided.

@mayfield
Copy link
Author

Fixes #1123

@mayfield mayfield mentioned this pull request Nov 30, 2017
Closed
@kamilogorek
Copy link
Contributor

Thanks for the PR.
We don't want to introduce more configuration options. Fetch should be chosen by default when available.
We also need some tests to cover this change.

@kamilogorek kamilogorek mentioned this pull request Nov 30, 2017
Merged
@kamilogorek
Copy link
Contributor

Fixed in #1157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayfield @kamilogorek