fix: Correct sampleRate behaviour #1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
kamilogorek
force-pushed
the
fix-sample-rate
branch
from
327edb5 to
7832440
Compare
Generated by 🚫 dangerJS |
HazAT
approved these changes
Oct 8, 2018
pashoo2
reviewed
Dec 2, 2020
| if (typeof sampleRate === 'number' && sampleRate > Math.random()) { | ||
| // 1.0 === 100% events are sent | ||
| // 0.0 === 0% events are sent | ||
| if (typeof sampleRate === 'number' && Math.random() > sampleRate) { |
There was a problem hiding this comment.
As far as i know Math.random() is not a valid random generator
i think better to use some kind of the https://github.com/ckknight/random-js
There was a problem hiding this comment.
Sure, it's not security-grade randomness, but it'll do just fine for sampling :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1625