Skip to content

fix: Correct sampleRate behaviour #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2018
Merged

fix: Correct sampleRate behaviour #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
- [node] feat: Transactions handling for RequestHandler in Express/Hapi
- [node] feat: Allow requestHandler to be configured
- [node] feat: Make node transactions a pluggable integration with tests
- [core] feat: getRequestheaders should handle legacy DSNs
- [core] fix: correct sampleRate behaviour

## 4.0.6

Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/baseclient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,9 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement

const { beforeSend, sampleRate } = this.getOptions();

if (typeof sampleRate === 'number' && sampleRate > Math.random()) {
// 1.0 === 100% events are sent
// 0.0 === 0% events are sent
if (typeof sampleRate === 'number' && Math.random() > sampleRate) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as i know Math.random() is not a valid random generator
i think better to use some kind of the https://github.com/ckknight/random-js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's not security-grade randomness, but it'll do just fine for sampling :)

return {
status: Status.Skipped,
};
Expand Down