Skip to content

[Bug Fix]: Adds fix for Vue attachProps, as it always evaluates true #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

ericnograles
Copy link
Contributor

@ericnograles ericnograles commented Mar 25, 2019

Summary

The original code from #1885 would always evaluate as true because of an incorrectly written ||. This code will actually set attachProps to false if it's passed in as such.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • [ x ] If you've added code that should be tested, please add tests.
  • [ x ] Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@HazAT HazAT merged commit ecf2bc1 into getsentry:master Mar 26, 2019
@kamilogorek
Copy link
Contributor

Embarassing :D

@ericnograles
Copy link
Contributor Author

🤐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants