Skip to content

[Bug Fix]: Adds fix for Vue attachProps, as it always evaluates true #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2019
Merged

[Bug Fix]: Adds fix for Vue attachProps, as it always evaluates true #1956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/integrations/src/vue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,17 @@ export class Vue implements Integration {
* When set to false, Sentry will suppress reporting all props data
* from your Vue components for privacy concerns.
*/
private readonly _attachProps: boolean;
private readonly _attachProps: boolean = true;

/**
* @inheritDoc
*/
public constructor(options: { Vue?: any; attachProps?: boolean } = {}) {
// tslint:disable-next-line: no-unsafe-any
this._Vue = options.Vue || getGlobalObject().Vue;
this._attachProps = options.attachProps || true;
if (options.attachProps === false) {
this._attachProps = false;
}
}

/** JSDoc */
Expand Down