Skip to content

ref(replay): Remove unused initialFlushDelay option #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

ref(replay): Remove unused initialFlushDelay option #6867

merged 1 commit into from
Jan 20, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 19, 2023

This is not in use anymore - we always flush immediately on load. So we can remove this option.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Jan 19, 2023
@mydea mydea requested review from billyvg and Lms24 January 19, 2023 12:56
@mydea mydea self-assigned this Jan 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.82 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 61.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 54.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.21 KB (0%)
@sentry/browser - Webpack (minified) 66.17 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.24 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.48 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.74 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.26 KB (-0.04% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.04 KB (-0.03% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.52 KB (-0.04% 🔽)

@mydea mydea force-pushed the fn/remove-initial-flush-delay branch from 87ee11b to aed8a4e Compare January 19, 2023 13:15
Lms24
Lms24 approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mydea
ref(replay): Remove unused initialFlushDelay option
79f8dd0 
This is not in use anymore - we always flush immediately on load.
@mydea mydea force-pushed the fn/remove-initial-flush-delay branch from aed8a4e to 79f8dd0 Compare January 20, 2023 09:30
@mydea mydea merged commit c63c6d9 into master Jan 20, 2023
@mydea mydea deleted the fn/remove-initial-flush-delay branch January 20, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24