Skip to content

ref(replay): Remove unused initialFlushDelay option #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2023
Merged

ref(replay): Remove unused initialFlushDelay option #6867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/integration-tests/suites/replay/captureReplayViaBrowser/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as Sentry from '@sentry/browser';
window.Sentry = Sentry;
window.Replay = new Sentry.Replay({
flushMinDelay: 200,
initialFlushDelay: 200,
flushMaxDelay: 200,
});

Sentry.init({
Expand Down
2 changes: 1 addition & 1 deletion packages/integration-tests/suites/replay/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Replay } from '@sentry/replay';
window.Sentry = Sentry;
window.Replay = new Replay({
flushMinDelay: 200,
initialFlushDelay: 200,
flushMaxDelay: 200,
});

Sentry.init({
Expand Down
2 changes: 1 addition & 1 deletion packages/integration-tests/suites/replay/sampling/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Replay } from '@sentry/replay';
window.Sentry = Sentry;
window.Replay = new Replay({
flushMinDelay: 200,
initialFlushDelay: 200,
flushMaxDelay: 200,
});

Sentry.init({
Expand Down
1 change: 0 additions & 1 deletion packages/replay/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export const MASK_ALL_TEXT_SELECTOR = 'body *:not(style), body *:not(script)';
/** Default flush delays */
export const DEFAULT_FLUSH_MIN_DELAY = 5_000;
export const DEFAULT_FLUSH_MAX_DELAY = 5_000;
export const INITIAL_FLUSH_DELAY = 5_000;

export const RETRY_BASE_INTERVAL = 5000;
export const RETRY_MAX_COUNT = 3;
3 changes: 0 additions & 3 deletions packages/replay/src/integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
DEFAULT_FLUSH_MAX_DELAY,
DEFAULT_FLUSH_MIN_DELAY,
DEFAULT_SESSION_SAMPLE_RATE,
INITIAL_FLUSH_DELAY,
MASK_ALL_TEXT_SELECTOR,
} from './constants';
import { ReplayContainer } from './replay';
Expand Down Expand Up @@ -43,7 +42,6 @@ export class Replay implements Integration {
public constructor({
flushMinDelay = DEFAULT_FLUSH_MIN_DELAY,
flushMaxDelay = DEFAULT_FLUSH_MAX_DELAY,
initialFlushDelay = INITIAL_FLUSH_DELAY,
stickySession = true,
useCompression = true,
sessionSampleRate,
Expand Down Expand Up @@ -73,7 +71,6 @@ export class Replay implements Integration {
flushMinDelay,
flushMaxDelay,
stickySession,
initialFlushDelay,
sessionSampleRate: DEFAULT_SESSION_SAMPLE_RATE,
errorSampleRate: DEFAULT_ERROR_SAMPLE_RATE,
useCompression,
Expand Down
2 changes: 1 addition & 1 deletion packages/replay/src/replay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export class ReplayContainer implements ReplayContainerInterface {
this._updateSessionActivity();

this.eventBuffer = createEventBuffer({
useCompression: Boolean(this._options.useCompression),
useCompression: this._options.useCompression,
});

this._addListeners();
Expand Down
5 changes: 0 additions & 5 deletions packages/replay/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,6 @@ export interface ReplayPluginOptions extends SessionOptions {
*/
flushMaxDelay: number;

/**
* The amount of time to buffer the initial snapshot
*/
initialFlushDelay: number;

/**
* Attempt to use compression when web workers are available
*
Expand Down