Skip to content

Conversation

AbhiPrasad
Copy link
Member

I decided against adding feat(types): add profilesSampler option to node client type (#7385) to the 7.42.1 to keep it a patch version. This means profilesSampler will only be officially part of the public API starting 7.43.0 and above.

github-actions bot and others added 15 commits March 9, 2023 13:39
[Gitflow] Merge master into develop
…ndles (#7391)

Add an initial version of `Sentry.init` call injection to our new SvelteKit SDK:
Specifically, we add a `withSentryViteConfig` wrapper function, which users will need to wrap around their Vite config. This will:

* Inject a Vite plugin which takes care of injecting `Sentry.init` calls from `sentry.(client|server).config.(ts|js)` files, providing a DX identical to the NextJS SDK.
  * The server-side init is injected into the server `index.js` file
  * The client-side init is injected into the `app.js` file 
  * The injection works both for production builds (with the Node adapter for now) as well as for a local dev server
* Add the root directory of the project to the allowed directories for the Vite dev server. We need this so that the client config is correctly picked up by the Vite dev server.
)

AddsSDK `init` functions for the SvelteKit server- and client-side SDK. Currently these functions 

* set SDK metadata
* call the respective base SDK's init
* set a `runtime` tag ('browser' / 'node' resp.)

Also fix a bug in the Svelte SDK where passed in `options._metadata.sdk` was previously overwritten with the Svelte SDKs data.
…7430)

Partially revert #7377 which caused monkey patching errors when patching the native `http` and `https` modules in the Node SDK (#7425). Similarly, also our Serverless SDK was subjected to the same problem (#7421). 

The problem is that `import` doesn't permit monkey patching of the imported (`http(s)`) module, producing this error:

```bash
TypeError: Cannot assign to read only property 'get' of object '[object Module]'
```

I tried using a dynamic import instead but got the same result. So it seems like we can only use `require` here :(
@AbhiPrasad AbhiPrasad requested review from a team, mydea and lforst and removed request for a team March 13, 2023 12:52
@AbhiPrasad AbhiPrasad changed the base branch from develop to master March 13, 2023 12:53
@AbhiPrasad
Copy link
Member Author

Will wait for #7434 to include in the release

@AbhiPrasad
Copy link
Member Author

Since we are merging in #7436, I'm going to close this and make it a minor

@AbhiPrasad AbhiPrasad closed this Mar 13, 2023
@AbhiPrasad AbhiPrasad deleted the prepare-release/7.42.1 branch March 13, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants