CodePush iOS/Android with Hermes showing wrong line numbers RN0.68/Sentry SDK7/Self-Hosted 22.5.0

[kopax-polyconseil]

OS:

• Windows (not tested as we don't use Windows)
• MacOS
• Linux

Platform:

• iOS
• Android

SDK:

• @sentry/react-native (>= 1.0.0)

{
  "dependencies": {
    "react-native": "^0.68.2",
    "@sentry/react": "^7.6.0",
    "@sentry/react-native": "^4.1.2",
    "@sentry/tracing": "^7.6.0"
  },
  "devDependencies": {
    "@sentry/types": "^7.6.0",
    "@sentry/webpack-plugin": "^1.18.9"
  }
}

react-native version: 0.68.2

Are you using Expo?

• Yes
• No

Are you using sentry.io or on-premise?

• sentry.io (SaaS)
• on-premise v22.5.0

If you are using sentry.io, please post a link to your issue so we can take a look:

NA

Configuration:

import { Platform } from 'react-native'
import CodePush from 'react-native-code-push'

import { env } from 'libs/environment'

import { version, build } from '../../../package.json'

export async function getSentryConfig() {
  let update
  try {
    update = await CodePush.getUpdateMetadata()
  } catch (error) {
    // silent fail
  }

  let release = `${version}-${Platform.OS}`
  if (update) {
    release += `+codepush:${update.label}`
  }
  const dist = `${build}-${Platform.OS}`
  return {
    dsn: env.SENTRY_DSN,
    environment: env.ENV,
    release,
    dist,
  }
}

---

I have following issue:

Following #2244 and #2087 closed too early, this is how we generate the sourcemaps, we used all of your recommendations, but still can't use source map with Android/iOS app after code push, which we often use.

iOS hard and android Hard work fine since your last investigation regarding iOS and Android matter, but this is what code push does.

Steps to reproduce: :

• Step 1: create a build hard iOS or Android published on appcenter or stores
• Step 2 : update the code base and provide change through app center code push
• Step 3 : manually generate sourcemaps and upload them to sentry with a custom dist and release pair
• Step 4 : send an error to sentry

Actual result:

iOS

Android

Expected result:

We expect to see proper sourcemaps line as for our iOS and Android hard build

[bruno-garcia]

Thanks for raising. There has been some changes recently in Hermes, that might be the cause. We'll need to look into this before we can get back to you.

[kopax-polyconseil]

Thanks for your reply, I though after closing my first issue and another that Code Push should now be fixed, I must have misunderstood.

Could you please share where can I find the information of when was introduced those Hermes change?

FYI, it never used to work with manual sourcemaps upload, perhaps because the iOS and Android build step for manual source maps upload where wrong until recently.

[marandaneto]

@kopax-polyconseil if you are using Hermes and manually uploading source maps, everything should work out.
The docs are up to date for that scenario.
About Code Push, can you share your code snippets on how you init the Sentry SDK, the CodePush SDK and the uploading scripts for Sentry and Code Push?

[kopax-polyconseil]

everything should work out

Could you please share what version did you test ?

The docs are up to date for that scenario.

I think the code push and hard build source maps generation step are the same, also if I am correct, the only way to use code push and sourcemaps is through manual sourcemaps upload, so I don't get what you are actually digging on.

Can you please clarify where can I find the doc for code push AND hermes to see if they are difference between the two?

About Code Push, can you share your code snippets

I did share previously a working minimal reproduction that you can build on your end, but I will also add snippets below, if you need to clarify dont hesitate to ask for more details of any part, this as been a big pain for our team to debug without the sourcemaps and we are commited to participate to this problem resolution.

init the Sentry SDK

• init call: https://github.com/pass-culture/pass-culture-app-native/blob/a7225b9eed01f3ace3f4280e8b6f5e4f8fdc29c5/src/libs/monitoring/services.ts#L28
• config : https://github.com/pass-culture/pass-culture-app-native/blob/a7225b9eed01f3ace3f4280e8b6f5e4f8fdc29c5/src/libs/monitoring/config.ts#L8-L27

the CodePush SDK

• init : https://github.com/pass-culture/pass-culture-app-native/blob/a7225b9eed01f3ace3f4280e8b6f5e4f8fdc29c5/src/App.tsx#L112
• options : https://github.com/pass-culture/pass-culture-app-native/blob/master/src/libs/codepush/options.tsx

the uploading scripts for Sentry and Code Push

• https://github.com/pass-culture/pass-culture-app-native/blob/master/scripts/upload_sourcemaps_to_sentry.sh

[marandaneto]

@kopax-polyconseil there are no docs for Hermes and CodePush, they are different things that can be used together.
If you want to manually generate source maps for Hermes, Follow the docs.
If you want to use CodePush, Follow the docs.
The most important part here is that release and dist should match.

I still don't have your code push scripts, when do you call the appcenter CLI and with which parameters?
Also, instead of using sentry-cli releases, you should follow the CodePush docs and use the sentry-cli react-native appcenter commands with the correct parameters.