Ref(internal) do not use npm swiftlint. #5215

lucas-zimerman · 2025-09-26T16:34:31Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Swiftlint is broken on the latest ubuntu VM, the package that contains the binaries for the linter is a year old, so there might be some compatibility issue with it.

Solution is to download swiftlinter and swift from their original sources and use it.

💡 Motivation and Context

We can't publish the SDK without a working swift linter.
Fixes #5213

💚 How did you test it?

on a arch/macos device/CI too

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

… into lz/lint-test

lucas-zimerman · 2025-09-26T17:33:25Z

New setup introduces 28 - 58 seconds on build and test run, we could skip it if the PR didn't touch any swift files.

.github/workflows/buildandtest.yml

lucas-zimerman · 2025-09-26T17:45:11Z

.github/workflows/buildandtest.yml

+          ./swiftly init --quiet-shell-followup
+          . "${SWIFTLY_HOME_DIR:-$HOME/.local/share/swiftly}/env.sh"
+          hash -r
+          sudo apt-get -y install libcurl4-openssl-dev


swiftly recommends this package install when installing swift

scripts/swiftlint.sh

…act-native into lz/lint-test

github-actions · 2025-09-26T18:11:25Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	449.85 ms	470.48 ms	20.63 ms
Size	17.75 MiB	19.69 MiB	1.94 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`1853710`	555.47 ms	556.59 ms	1.12 ms
`5c16cdc`+dirty	423.48 ms	452.35 ms	28.88 ms
`20d5eaa`	377.62 ms	406.50 ms	28.88 ms
`23080e5`	384.85 ms	382.57 ms	-2.28 ms
`64cd15c`	439.02 ms	427.63 ms	-11.39 ms
`d751a5d`+dirty	434.24 ms	486.08 ms	51.84 ms
`77061ed`+dirty	369.55 ms	408.35 ms	38.80 ms
`e2fa43d`	451.68 ms	462.42 ms	10.74 ms
`2b89ce9`	413.69 ms	442.58 ms	28.89 ms
`eb07ba3`	470.04 ms	473.35 ms	3.31 ms

App size

Revision	Plain	With Sentry	Diff
`1853710`	17.75 MiB	19.68 MiB	1.94 MiB
`5c16cdc`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`20d5eaa`	17.75 MiB	20.15 MiB	2.41 MiB
`23080e5`	17.75 MiB	19.68 MiB	1.94 MiB
`64cd15c`	17.75 MiB	20.15 MiB	2.41 MiB
`d751a5d`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`77061ed`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`e2fa43d`	17.75 MiB	20.15 MiB	2.41 MiB
`2b89ce9`	17.75 MiB	19.68 MiB	1.94 MiB
`eb07ba3`	17.75 MiB	20.15 MiB	2.41 MiB

Previous results on branch: lz/lint-test

Startup times

Revision	Plain	With Sentry	Diff
`a9a7b9b`+dirty	431.52 ms	447.68 ms	16.16 ms

App size

Revision	Plain	With Sentry	Diff
`a9a7b9b`+dirty	17.75 MiB	19.68 MiB	1.94 MiB

github-actions · 2025-09-26T18:17:58Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1212.02 ms	1232.06 ms	20.04 ms
Size	2.63 MiB	3.98 MiB	1.34 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`7480abe`+dirty	1220.53 ms	1244.18 ms	23.65 ms
`77061ed`+dirty	1233.16 ms	1234.88 ms	1.71 ms
`534ba8c`+dirty	1230.22 ms	1231.18 ms	0.96 ms
`46da307`+dirty	1217.08 ms	1224.16 ms	7.08 ms
`23080e5`+dirty	1216.02 ms	1224.94 ms	8.91 ms
`21c9e75`+dirty	1237.78 ms	1247.66 ms	9.88 ms
`5526494`+dirty	1224.73 ms	1229.08 ms	4.36 ms
`d751a5d`+dirty	1215.57 ms	1220.56 ms	4.99 ms
`69602ce`+dirty	1235.65 ms	1230.82 ms	-4.83 ms
`c08359e`+dirty	1235.25 ms	1233.96 ms	-1.29 ms

App size

Revision	Plain	With Sentry	Diff
`7480abe`+dirty	2.63 MiB	3.96 MiB	1.33 MiB
`77061ed`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`534ba8c`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`46da307`+dirty	2.63 MiB	3.87 MiB	1.24 MiB
`23080e5`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`21c9e75`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`5526494`+dirty	2.63 MiB	3.87 MiB	1.24 MiB
`d751a5d`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`69602ce`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`c08359e`+dirty	2.63 MiB	3.81 MiB	1.18 MiB

Previous results on branch: lz/lint-test

Startup times

Revision	Plain	With Sentry	Diff
`a9a7b9b`+dirty	1242.47 ms	1235.00 ms	-7.47 ms

App size

Revision	Plain	With Sentry	Diff
`a9a7b9b`+dirty	2.63 MiB	3.98 MiB	1.34 MiB

github-actions · 2025-09-26T18:21:44Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	370.46 ms	410.42 ms	39.96 ms
Size	7.15 MiB	8.42 MiB	1.26 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`af9331b`+dirty	374.42 ms	425.68 ms	51.26 ms
`69602ce`+dirty	375.37 ms	405.28 ms	29.91 ms
`5c16cdc`+dirty	375.45 ms	426.62 ms	51.17 ms
`c08359e`+dirty	406.04 ms	428.87 ms	22.83 ms
`c7f264b`+dirty	356.98 ms	407.46 ms	50.48 ms
`98f632c`+dirty	323.98 ms	375.39 ms	51.41 ms
`ba75c7c`+dirty	377.92 ms	417.74 ms	39.83 ms
`8ece263`+dirty	369.44 ms	414.65 ms	45.21 ms
`d751a5d`+dirty	341.61 ms	403.06 ms	61.45 ms
`77061ed`+dirty	359.40 ms	424.10 ms	64.70 ms

App size

Revision	Plain	With Sentry	Diff
`af9331b`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`69602ce`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`5c16cdc`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`c08359e`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`c7f264b`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`98f632c`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`ba75c7c`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`8ece263`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`d751a5d`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`77061ed`+dirty	7.15 MiB	8.41 MiB	1.26 MiB

Previous results on branch: lz/lint-test

Startup times

Revision	Plain	With Sentry	Diff
`a9a7b9b`+dirty	352.78 ms	409.77 ms	56.99 ms

App size

Revision	Plain	With Sentry	Diff
`a9a7b9b`+dirty	7.15 MiB	8.41 MiB	1.26 MiB

github-actions · 2025-09-26T18:29:11Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1237.90 ms	1250.76 ms	12.86 ms
Size	3.19 MiB	4.54 MiB	1.36 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`7480abe`+dirty	1219.84 ms	1223.60 ms	3.76 ms
`77061ed`+dirty	1210.77 ms	1218.45 ms	7.68 ms
`534ba8c`+dirty	1225.00 ms	1237.43 ms	12.43 ms
`46da307`+dirty	1213.45 ms	1207.96 ms	-5.49 ms
`23080e5`+dirty	1221.39 ms	1222.08 ms	0.70 ms
`21c9e75`+dirty	1206.20 ms	1223.54 ms	17.35 ms
`5526494`+dirty	1217.06 ms	1222.26 ms	5.20 ms
`d751a5d`+dirty	1212.22 ms	1217.94 ms	5.71 ms
`69602ce`+dirty	1230.59 ms	1230.84 ms	0.24 ms
`c08359e`+dirty	1200.59 ms	1211.81 ms	11.22 ms

App size

Revision	Plain	With Sentry	Diff
`7480abe`+dirty	3.19 MiB	4.53 MiB	1.35 MiB
`77061ed`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`534ba8c`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`46da307`+dirty	3.19 MiB	4.44 MiB	1.25 MiB
`23080e5`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`21c9e75`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`5526494`+dirty	3.19 MiB	4.44 MiB	1.25 MiB
`d751a5d`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`69602ce`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`c08359e`+dirty	3.19 MiB	4.38 MiB	1.19 MiB

Previous results on branch: lz/lint-test

Startup times

Revision	Plain	With Sentry	Diff
`a9a7b9b`+dirty	1238.33 ms	1231.23 ms	-7.10 ms

App size

Revision	Plain	With Sentry	Diff
`a9a7b9b`+dirty	3.19 MiB	4.54 MiB	1.36 MiB

scripts/swiftlint.sh

antonis

LGTM and works as expected both on CI and locally 🚀
Thank you for fixing this @lucas-zimerman 🙇

Added a nit for some lines that I think are not used.

Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>

lucas-zimerman added 14 commits September 26, 2025 14:52

test nocache

f99799e

swift / arch validated

be9e9c8

gh setup

0c3c3dd

6.2.0 not supported

d536ed1

skip verify

6c2d7bd

use swiftly

9397871

split swiftly and swift

b3cb7ba

missing bits

efe310e

wip

137471d

move priority / WIP

25b4425

mor steps

728b963

package sync

d4184a2

Merge branch 'main' of https://github.com/getsentry/sentry-react-native…

6f530e0

… into lz/lint-test

rollback swift check:

7441e6b

remove mention of macos since it already bundles swift with xcode

f5f49a7

lucas-zimerman marked this pull request as ready for review September 26, 2025 17:42

lucas-zimerman requested review from alwx and antonis as code owners September 26, 2025 17:42

lucas-zimerman commented Sep 26, 2025

View reviewed changes

.github/workflows/buildandtest.yml Outdated Show resolved Hide resolved

Apply suggestion from @lucas-zimerman

f0bfbc1

lucas-zimerman commented Sep 26, 2025

View reviewed changes

scripts/swiftlint.sh Outdated Show resolved Hide resolved

Apply suggestion from @lucas-zimerman

4b0f955

seer-by-sentry bot reviewed Sep 26, 2025

View reviewed changes

scripts/swiftlint.sh Show resolved Hide resolved

lucas-zimerman added 2 commits September 26, 2025 18:54

nit

b3c7a46

Merge branch 'lz/lint-test' of https://github.com/getsentry/sentry-re…

f86eb77

…act-native into lz/lint-test

antonis reviewed Sep 29, 2025

View reviewed changes

scripts/swiftlint.sh Outdated Show resolved Hide resolved

antonis approved these changes Sep 29, 2025

View reviewed changes

lucas-zimerman and others added 2 commits September 29, 2025 18:23

Apply suggestion from @antonis

64fe247

Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>

Merge branch 'main' into lz/lint-test

e211c03

lucas-zimerman enabled auto-merge (squash) September 29, 2025 17:23

lucas-zimerman merged commit cba5aef into main Sep 29, 2025
63 checks passed

lucas-zimerman deleted the lz/lint-test branch September 29, 2025 17:27

antonis pushed a commit that referenced this pull request Sep 30, 2025

Ref(internal) do not use npm swiftlint. (#5215)

9be0807

antonis mentioned this pull request Sep 30, 2025

chore: V6: Bug Fix Release v6.22.0 #5220

Merged

10 tasks

Uh oh!

Ref(internal) do not use npm swiftlint. #5215

Ref(internal) do not use npm swiftlint. #5215

Conversation

lucas-zimerman commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

lucas-zimerman commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lucas-zimerman Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: lz/lint-test

Startup times

App size

Uh oh!

github-actions bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: lz/lint-test

Startup times

App size

Uh oh!

github-actions bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: lz/lint-test

Startup times

App size

Uh oh!

github-actions bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: lz/lint-test

Startup times

App size

Uh oh!

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lucas-zimerman commented Sep 26, 2025 •

edited

Loading

lucas-zimerman commented Sep 26, 2025 •

edited

Loading

github-actions bot commented Sep 26, 2025 •

edited

Loading

github-actions bot commented Sep 26, 2025 •

edited

Loading

github-actions bot commented Sep 26, 2025 •

edited

Loading

github-actions bot commented Sep 26, 2025 •

edited

Loading