Skip to content

Checking if stacktrace exists before accessing it #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Checking if stacktrace exists before accessing it #594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions android/src/main/java/io/sentry/RNSentryModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,14 +265,16 @@ public void captureEvent(ReadableMap event) {
if (event.hasKey("exception")) {
ReadableNativeArray exceptionValues = (ReadableNativeArray)event.getMap("exception").getArray("values");
ReadableNativeMap exception = exceptionValues.getMap(0);
ReadableNativeMap stacktrace = exception.getMap("stacktrace");
ReadableNativeArray frames = (ReadableNativeArray)stacktrace.getArray("frames");
if (exception.hasKey("value")) {
addExceptionInterface(eventBuilder, exception.getString("type"), exception.getString("value"), frames);
} else {
// We use type/type here since this indicates an Unhandled Promise Rejection
// https://github.com/getsentry/react-native-sentry/issues/353
addExceptionInterface(eventBuilder, exception.getString("type"), exception.getString("type"), frames);
if (exception.hasKey("stacktrace")) {
ReadableNativeMap stacktrace = exception.getMap("stacktrace");
ReadableNativeArray frames = (ReadableNativeArray)stacktrace.getArray("frames");
if (exception.hasKey("value")) {
addExceptionInterface(eventBuilder, exception.getString("type"), exception.getString("value"), frames);
} else {
// We use type/type here since this indicates an Unhandled Promise Rejection
// https://github.com/getsentry/react-native-sentry/issues/353
addExceptionInterface(eventBuilder, exception.getString("type"), exception.getString("type"), frames);
}
}
}

Expand Down