Skip to content

write the panics section for functions that may panic #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

write the panics section for functions that may panic #174

merged 1 commit into from
Feb 19, 2020

Conversation

KeenS
Copy link
Contributor

@KeenS KeenS commented Jan 7, 2020

Functions that may panic should have the panics section

@KeenS
Copy link
Contributor Author

KeenS commented Jan 7, 2020

CI is failing but all of them are irrelevant to this PR...

jan-auer
jan-auer approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jan-auer jan-auer merged commit b657c15 into getsentry:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KeenS @jan-auer