ref(timeseries): Use /events-timeseries/ on Insights Overview pages
#100144
+93
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const count = jobCounts[i]?.value!; | ||
| jobsCount += count; | ||
| errorCount += point.value! * count; | ||
| errorCount += item.value! * count; |
There was a problem hiding this comment.
Bug: Error Rate Calculation Fails with Undefined Values
The overallErrorRate calculation has a couple of issues. An unsafe non-null assertion on jobCounts[i]?.value! might cause a runtime error if jobCounts[i] is undefined (e.g., due to differing array lengths). Also, if jobsCount is zero (e.g., from empty arrays), the division results in NaN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to replace usage of
/events-stats/with/events-timeseries/This time, it's some usage on Insights landing pages, wherever we're not making angroupByquery. I had to make a few code changes to accommodate the new format, but for the most part things are a bit simpler now, with no need to convert data formats.