fix(aci): Record DetectorGroup associations for new error groups #100684
+79
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
saponifi3d
approved these changes
Oct 3, 2025
| detector_id=occurrence.evidence_data["detector_id"], | ||
| group_id=group.id, | ||
| ) | ||
| associate_new_group_with_detector(group, occurrence.evidence_data["detector_id"]) |
There was a problem hiding this comment.
🎉 nice - i couldn't find any other occurrences of creating this either.
|
with the future of having this be updated by a background job, will there be any other data migrations we'll need to keep in mind? It sounds like at the given growth rate, this will likely buy us like a month or two. |
I don't understand the question, but I'm not aware of other data migrations we'll need to keep in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guarded behind a flag for now.
We expect this to be 140k-190k writes per hour, expected to double the scale of DetectorGroup in under a week.