chore(sentry-apps): move sentry apps to async deletion #100840
Merged
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
I don't believe we need any UI updates because I immediately mark the deletion as in progress right before scheduling it. From past experience the UI doesn't show Sentry Apps that have this status (+ they're currently not fully deleted because Sentry App inherits from |
Christinarlong
approved these changes
Oct 3, 2025
|
@Christinarlong you tested it locally and it removes the sentry app as expected |
GabeVillalobos
approved these changes
Oct 3, 2025
Comment on lines
+238
to
+239
| sentry_app.update(status=SentryAppStatus.DELETION_IN_PROGRESS) | ||
| scheduled = ScheduledDeletion.schedule(sentry_app, days=0, actor=request.user) |
There was a problem hiding this comment.
If we find ourselves using this pattern in other contexts, let's consider moving this to a service class that manages sentry app deletions/updates for us. Encoding this behavior in endpoints has bit us in the past when implementations differ by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for #100813 because we are now making a RPC call when deleting Sentry apps, and they are not allowed within transactions.