feat(eap): Support numeric values in eap count_unique #100889
Merged
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows count_unique to take numeric attributes as an argument.
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100889 +/- ##
===========================================
- Coverage 81.15% 81.14% -0.01%
===========================================
Files 8615 8615
Lines 382250 382256 +6
Branches 24033 24033
===========================================
- Hits 310199 310198 -1
- Misses 71723 71730 +7
Partials 328 328 |
Zylphrex
added a commit
that referenced
this pull request
Oct 3, 2025
Numeric attributes should be permitted as an argument to count_unique. Requires #100889 Frontend for LOGS-398
JoshFerge
approved these changes
Oct 3, 2025
Zylphrex
deleted the
txiao/feat/support-numeric-values-in-eap-count-unique
branch
jasonyuezhang
pushed a commit
to jasonyuezhang/sentry
that referenced
this pull request
Oct 3, 2025
Numeric attributes should be permitted as an argument to count_unique. Requires getsentry#100889 Frontend for LOGS-398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows count_unique to take numeric attributes as an argument.
Backend for LOGS-398