ref(grouping): Include variant.contributes in grouping info JSON
#100893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100893 +/- ##
===========================================
- Coverage 81.14% 81.14% -0.01%
===========================================
Files 8616 8616
Lines 382235 382235
Branches 24032 24032
===========================================
- Hits 310179 310177 -2
- Misses 71728 71730 +2
Partials 328 328 |
lobsterkatie
force-pushed
the
kmclb-include-variant-contributes-in-grouping-info-json
branch
from
4278046 to
29d7923
Compare
lobsterkatie
force-pushed
the
kmclb-include-variant-contributes-in-grouping-info-json
branch
from
29d7923 to
bc534cc
Compare
shayna-ch
approved these changes
Oct 3, 2025
lobsterkatie
deleted the
kmclb-include-variant-contributes-in-grouping-info-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds each variant's
contributesvalue to the JSON used in the grouping info section of the issue details page. Once this is deployed, a follow-up PR will switch the front end code to use this value (rather than the presence of a hash value) to determine whether or not the variant contributes, which will make handling certain special cases easier. (We'll be able to force a variant to show without incurring all of the side effects of adding a hash value.)